Bug 462882 - Site Info replace OK by Close
Summary: Site Info replace OK by Close
Status: REPORTED
Alias: None
Product: Falkon
Classification: Applications
Component: extensions (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-11 06:52 UTC by genghiskhan
Modified: 2022-12-18 07:33 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description genghiskhan 2022-12-11 06:52:07 UTC 
Replace OK button by Close
Comment 1 Juraj 2022-12-17 12:36:20 UTC 
I am against this since there is a work in progress to add more functions to this dialog and "OK" button will be used to confirm and close the dialog.
Comment 2 Juraj 2022-12-17 12:37:14 UTC 
Correction, this relates only to SiteInfo, the rest will need to be checked.
OK is fine, why to change it?
Comment 3 genghiskhan 2022-12-18 07:33:53 UTC 
> OK is fine, why to change it?
Because, to me, OK is used to apply changes.

User sees OK button in Greasemonkey.
User: I think I should use the close button (of the window manager) or press Alt-F4. I don't want to approve changes I might have done.

> "OK" button will be used to confirm and close the dialog
Should AdBlock and Greasemonkey have a text saying "changes will be applied instantly", until new functions be added?