Bug 462549 - Clicking on the account switcher sometimes doesnt register
Summary: Clicking on the account switcher sometimes doesnt register
Status: RESOLVED FIXED
Alias: None
Product: NeoChat
Classification: Applications
Component: General (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Tobias Fella
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-02 14:19 UTC by Jan Bidler
Modified: 2023-02-02 21:19 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/network/neochat/commit/4066427168e4cde2800eec599539a603721185cb
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
nc account picker bug (258.59 KB, video/mp4)
2022-12-02 19:00 UTC, Jan Bidler 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Bidler 2022-12-02 14:19:19 UTC 
SUMMARY
Clicking on the account switcher sometimes doesnt register properly

STEPS TO REPRODUCE
1. Open neochat
2. click the account switcher icon a few times

OBSERVED RESULT
On a few occasions, while the icon looks like it registered a click, the account switcher popup doesn't react to it

EXPECTED RESULT
Account switcher popup should regurlaly (un)hide

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.26.4
KDE Frameworks Version: 5.100.0
Qt Version: 5.15.7
Kernel Version: 6.0.10-arch2-1 (64-bit)
Graphics Platform: Wayland
Processors: 12 × AMD Ryzen 5 1600 Six-Core Processor
Memory: 15.6 GiB of RAM
Graphics Processor: AMD Radeon RX 570 Series
Manufacturer: Gigabyte Technology Co., Ltd.
Product Name: B450M DS3H

NeoChat 22.11
Comment 1 Tobias Fella 2022-12-02 16:57:08 UTC 
Can't reproduce
Comment 2 Jan Bidler 2022-12-02 19:00:04 UTC 
Created attachment 154236 [details]
nc account picker bug

here's a video preview of it.
No text in the terminal about it
Comment 3 James Graham 2022-12-05 20:34:38 UTC 
I can reproduce this. If you click at the right pace (fast but not all out) sometimes a click is missed. I was able to confirm by making the button checkable and watching them change sync.
Comment 4 James Graham 2023-02-02 21:19:09 UTC 
Git commit 4066427168e4cde2800eec599539a603721185cb by James Graham.
Committed on 02/02/2023 at 21:19.
Pushed by nvrwhere into branch 'master'.

Fix Account Switcher Missing Clicks

Use a state machine to open and close the account switcher so clicks aren't missed.

M  +12   -8    src/qml/Component/UserInfo.qml

https://invent.kde.org/network/neochat/commit/4066427168e4cde2800eec599539a603721185cb