Bug 462097 - Task Manager icons are too small with a 38px panel, but only when using the Small or Normal spacing settings
Summary: Task Manager icons are too small with a 38px panel, but only when using the S...
Status: CLOSED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager widgets (other bugs)
Version First Reported In: 5.26.3
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: veggero
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-21 13:04 UTC by subhuman2222
Modified: 2023-02-01 16:00 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27
Sentry Crash Report:


Attachments
self-explanatory (62.30 KB, image/png)
2022-11-21 13:04 UTC, subhuman2222
Details

Note You need to log in before you can comment on or make changes to this bug.
Description subhuman2222 2022-11-21 13:04:02 UTC
Created attachment 153926 [details]
self-explanatory

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Set the panel height to 38
2. Play with icon spacings or plasma styles

OBSERVED RESULT
After an update, icons use their proper scaling only with 40 px height. Now panel (i used height of 38) shows me small icons. If i change the Plasma style to Oxygen, that icon scale is back. Also if I turn off bigger spacing between icons they become ok.

EXPECTED RESULT
Icons-only taskbar icons would scale exactly like before the update.
Expected icon scaling with 38 panel height would be with Oxygen Plasma style or with stock Breeze + "Large" spacing between app icons, just like it was before the 5.26.3(?) update. (I did use Normal spacing before the update).

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Artix Linux x86_64
(available in About System)
KDE Plasma Version: 5.26.3
KDE Frameworks Version: 5.100.0
Qt Version: 5.15.7

ADDITIONAL INFORMATION
I use X11 with nvidia packages installed.
Comment 1 Nate Graham 2022-11-21 21:23:56 UTC
Can confirm.

Not sure what the true bug is here, though:
1. The fact that the icons *don't* switch to the next largest size with a 38px oanel
2. The fact that the icons *do* switch to the next largest size at 38px panel when you're using the large spacing setting

Definitely at least one of those should be fixed.
Comment 2 subhuman2222 2022-11-22 07:22:19 UTC
(In reply to Nate Graham from comment #1)
> Can confirm.
> 
> Not sure what the true bug is here, though:
> 1. The fact that the icons *don't* switch to the next largest size with a
> 38px oanel
> 2. The fact that the icons *do* switch to the next largest size at 38px
> panel when you're using the large spacing setting
> 
> Definitely at least one of those should be fixed.

well, the icons did switch to the next largest size before, so (i wish) number 1 should be fixed
Comment 3 veggero 2022-11-22 13:47:59 UTC
I'm afraid the bug is 2, not 1.  Sorry
Comment 4 subhuman2222 2022-11-22 17:41:52 UTC
(In reply to veggero from comment #3)
> I'm afraid the bug is 2, not 1.  Sorry

well i just hope it will look like it looked all these years
Comment 5 Bug Janitor Service 2023-01-27 20:05:26 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1362
Comment 6 Nate Graham 2023-02-01 15:59:21 UTC
Git commit 0ed0ae8a90e44f34d67495e650d520965352c21c by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 01/02/2023 at 15:59.
Pushed by ngraham into branch 'master'.

applets/taskmanager: Fix icon size when spacing is set to large

By applying the 3x margins on "large" spacing to both horizontal and vertical margins,
we're also compressing the icon to be too small by triggering a condition in the
minimum size check. With this commit, switching to "large" while the panel is at 38px
shouldn't change the size of the icon anymore.
FIXED-IN: 5.27

M  +2    -2    applets/taskmanager/package/contents/ui/code/layout.js

https://invent.kde.org/plasma/plasma-desktop/commit/0ed0ae8a90e44f34d67495e650d520965352c21c
Comment 7 Nate Graham 2023-02-01 15:59:50 UTC
Git commit 2b03cd33ea7e9149b995985a5e029552ace5a7db by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 01/02/2023 at 15:59.
Pushed by ngraham into branch 'Plasma/5.27'.

applets/taskmanager: Fix icon size when spacing is set to large

By applying the 3x margins on "large" spacing to both horizontal and vertical margins,
we're also compressing the icon to be too small by triggering a condition in the
minimum size check. With this commit, switching to "large" while the panel is at 38px
shouldn't change the size of the icon anymore.
FIXED-IN: 5.27


(cherry picked from commit 0ed0ae8a90e44f34d67495e650d520965352c21c)

M  +2    -2    applets/taskmanager/package/contents/ui/code/layout.js

https://invent.kde.org/plasma/plasma-desktop/commit/2b03cd33ea7e9149b995985a5e029552ace5a7db
Comment 8 Nate Graham 2023-02-01 16:00:52 UTC
Note that the fix here was to make icons smaller when using the "Large" spacing, as the real bug was that they were too big when using "Large" spacing and a 38px panel. If you want icons to be bigger, make the panel 40px.