Bug 461846 - Icons not showing up in timeline
Summary: Icons not showing up in timeline
Status: RESOLVED FIXED
Alias: None
Product: Tokodon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-15 00:27 UTC by Tobias Fella
Modified: 2022-12-01 19:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot (2.62 KB, image/png)
2022-11-15 00:27 UTC, Tobias Fella
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Fella 2022-11-15 00:27:20 UTC
Created attachment 153753 [details]
Screenshot

See attachment

STEPS TO REPRODUCE
1.  Start tokodon
2. Profit :)

OBSERVED RESULT
No icons

EXPECTED RESULT
Icons

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora 36
KDE Plasma Version: Git
KDE Frameworks Version: Git
Qt Version:  5.15.6+KDE
Comment 1 Carl Schwan 2022-11-15 08:28:55 UTC
These icons are in the qrc, weird that it doesn't work :(
Comment 2 Joshua Goins 2022-12-01 02:10:50 UTC
It seems that Qt5 hates icons inside of ToolButtons for whatever reason. I'm making a custom component that fixes this issue, and I'll send an MR soon :-)
Comment 3 Joshua Goins 2022-12-01 02:39:38 UTC
I added this BUG post-mortem, but you can view the current draft MR here: https://invent.kde.org/network/tokodon/-/merge_requests/63
Comment 4 Carl Schwan 2022-12-01 19:33:13 UTC
Git commit e01fece898e24ce7bde0e90181d4836c9b5eb8e5 by Carl Schwan, on behalf of Joshua Goins.
Committed on 01/12/2022 at 19:28.
Pushed by carlschwan into branch 'master'.

Add InteractionButton component for likes, boosts and replies

Fixes interaction buttons not showing up due to ToolButton not
supporting SVGs. They follow standard Mastodon colors, as well as the
current color scheme too. Closes #34

M  +4    -0    .reuse/dep5
A  +54   -0    src/content/icon/reply-post.svg
A  +44   -0    src/content/ui/InteractionButton.qml     [License: GPL(v3.0+)]
M  +10   -12   src/content/ui/PostDelegate.qml
M  +2    -0    src/resources.qrc

https://invent.kde.org/network/tokodon/commit/e01fece898e24ce7bde0e90181d4836c9b5eb8e5