Bug 461762 - Restore the ability to not show the Number field in the ledger
Summary: Restore the ability to not show the Number field in the ledger
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: ux-ui (show other bugs)
Version: git (master)
Platform: Other Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-13 09:38 UTC by adi.sav
Modified: 2022-11-17 07:32 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: master
Sentry Crash Report:


Attachments
screenshot (379.60 KB, image/jpeg)
2022-11-13 09:38 UTC, adi.sav
Details
screenshot 2 (198.99 KB, image/jpeg)
2022-11-16 17:36 UTC, adi.sav
Details

Note You need to log in before you can comment on or make changes to this bug.
Description adi.sav 2022-11-13 09:38:54 UTC
Created attachment 153706 [details]
screenshot

Using build 1707 in Windows 11.

"Always show a No. field" from Ledger tab has no effect. I am attaching a screenshot where you can see that the option is unchecked and Apply button already pressed. But in the back the "No." column can still be seen.

I also checked version 5.1.3-261c598d3. There is no problem there, the checkbox works as it should.

Why is there that two versions of KMyMoney (nightly and stable) share the same config file, but only the stable respects the settings it finds there? Nightly ignores them :) Are they separate code branches?
Comment 1 Jack 2022-11-13 15:41:59 UTC
The stable releases are currently from the 5.1 branch, which gets bug fixes, but not new features.  The nightly build is from master branch, which should be considered a work in progress, with new features.  While there are a small number of folks (mostly the developers) who use it for their daily activity, it should not be considered stable, and there are often new bugs introduced.  In general, the master branch does NOT ignore configuration settings, but I can think of two cases where it does.  First, it may just be an inadvertent bug introduced when changing something else in a related area of code.  Second, if something about the design of the program changed, then it may not use some setting any more.  I am not aware of any intentional change related to showing the Number field, so we'll have to wait for input from a developer.
Comment 2 Thomas Baumgart 2022-11-13 15:46:44 UTC
Git commit 704bfbf07e1149d2c309f1ba1cecb5fda127f995 by Thomas Baumgart.
Committed on 13/11/2022 at 15:38.
Pushed by tbaumgart into branch 'master'.

Remove unused option 'Always show no field'
FIXED-IN: master

M  +0    -10   kmymoney/dialogs/settings/ksettingsregister.ui
M  +0    -4    kmymoney/settings/kmymoney.kcfg

https://invent.kde.org/office/kmymoney/commit/704bfbf07e1149d2c309f1ba1cecb5fda127f995
Comment 3 adi.sav 2022-11-14 18:25:03 UTC
@Jack
Thank you for the clear explanation.

@Thomas Baumgart
Using 1708 build.
Now the option is definitely gone from Settings > Legder, so I cannot technically complain of it not working, haha!
However, my intended fix would have been to let the option there, but have it work properly.
In fact, I wanted to get rid of the "No" column in the ledger. It takes up space and I am not even using a number for my transactions. I was glad I found the option to hide the field, it was exactly what I needed. That's how I found out it did not work and made this bug report.
Now the option is gone and the field is still there, without any possibility to make it go away :)))
Comment 4 Jack 2022-11-14 20:23:29 UTC
adi.sav - what you have here is not a bug, as it is an intentional design change in the program.  I've changed this to a wishlist, and reworded the subject to be a request to restore the ability to not show the Number field.  However, given the intentional change, I don't think it will get a high priority.  However, have you noticed that in the master branch, you can change the width of columns in the ledger?  You can't totally get rid of it, but you can certainly make it much smaller
Comment 5 Thomas Baumgart 2022-11-15 06:59:16 UTC
Git commit ccdcfdab7197d731e8b9eed771474f62def14b68 by Thomas Baumgart.
Committed on 15/11/2022 at 06:58.
Pushed by tbaumgart into branch 'master'.

Make number column in ledger view selectable
FIXED-IN: master

M  +8    -8    kmymoney/views/ledgerviewpage.cpp

https://invent.kde.org/office/kmymoney/commit/ccdcfdab7197d731e8b9eed771474f62def14b68
Comment 6 Thomas Baumgart 2022-11-15 07:01:04 UTC
I love those moments, when a feature can be implemented by removing a line of code due to the underlying design :)

adi.sav: Right click on the ledger's header to manage the global visibility of optional columns.
Comment 7 adi.sav 2022-11-16 17:36:22 UTC
Created attachment 153811 [details]
screenshot 2
Comment 8 adi.sav 2022-11-16 17:43:03 UTC
Well, I don't know what to say about that :)
Using build 1709.
In the right-click menu on the ledger's header I only have two options: Entry and Payee. See screenshot 2.
And it would be great to have "No." column there.

And it would be awesome to also have "C" column removable :)
Comment 9 Thomas Baumgart 2022-11-17 07:32:52 UTC
Build 1709 was based on commit 2ce71f06ed7 but that does not include the change I made (see below). Build 1710 failed for other reasons I have not looked into and Build 1711 contains the fix because it is based on commit dfb692d35a which includes the change.

Please don't simply reopen a bug ticket without investigating what you are doing as this is eats my time to find out that the problem in fact is a 'user problem' on your end and is solved by just waiting for the next build to come along. Thank you for considering that the next time. BTW, the list of commits is publicly available at https://invent.kde.org/office/kmymoney/-/commits/master.

commit ccdcfdab7197d731e8b9eed771474f62def14b68 (origin/master, origin/HEAD, master)
Author: Thomas Baumgart <thb@net-bembel.de>
Date:   Tue Nov 15 07:58:47 2022 +0100

    Make number column in ledger view selectable
    
    FEATURE: 461762
    FIXED-IN: master

commit 6667d6bf63cff24ac6faa0b3a6dd77f86e43e00a
Author: l10n daemon script <scripty@kde.org>
Date:   Tue Nov 15 02:13:11 2022 +0000

    GIT_SILENT Sync po/docbooks with svn

commit 27c8a9a30b18daf09767e8e8bf3f90854ac22d70
Author: l10n daemon script <scripty@kde.org>
Date:   Mon Nov 14 02:06:33 2022 +0000

    GIT_SILENT Sync po/docbooks with svn