Bug 461734 - macOS GUI improvements
Summary: macOS GUI improvements
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Bundle-MacOS (show other bugs)
Version: 7.8.0
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-12 16:42 UTC by M-Rick
Modified: 2023-04-09 06:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 8.0.0
Sentry Crash Report:


Attachments
Icons in macOS menus (72.29 KB, image/png)
2022-11-12 16:42 UTC, M-Rick
Details
Underscores in menu an on buttons (178.68 KB, image/png)
2022-11-12 16:43 UTC, M-Rick
Details

Note You need to log in before you can comment on or make changes to this bug.
Description M-Rick 2022-11-12 16:42:19 UTC
Created attachment 153690 [details]
Icons in macOS menus

On macOS, the GUI guideline do not recommend the use of icons in menus.
Plus, when using a dark them, the white icons aren't visible on a light theme.

And, is there a way to remove all the underscores appearing everywhere over the buttons or windows?
They are completely useless because macOS behaviour is different.
Comment 1 M-Rick 2022-11-12 16:43:04 UTC
Created attachment 153691 [details]
Underscores in menu an on buttons
Comment 2 Maik Qualmann 2022-11-12 19:54:37 UTC
The compiler flag for Qt to disable underscrored shortcuts is probably QT_NO_ACTION.
The issue of the icons (I think icons should be present in macOS as well), as well as the uninherited color theme for the menus, is more a matter for the underlying KXMLGui component.

Maik
Comment 3 caulier.gilles 2023-04-09 05:46:26 UTC
>The compiler flag for Qt to disable underscrored shortcuts is probably QT_NO_ACTION.

Under MacOS, Qt is compiled with macports rules. We will not touch this kind of configuration. Also disabing QT_NO_ACTION will have certainly side-effects.

I checked Krita 5 under MacOS, and underscrored shortcuts are presents in GUI.

About icons in menu, Krita do not show the icons at all. There is certainly an option to turn on/off quickly in KF5 API to disable this feature.

Gilles Caulier
Comment 4 caulier.gilles 2023-04-09 05:50:06 UTC
Menu icon solution with Qt API: https://forum.qt.io/topic/24960/solved-osx-menu-icons
Comment 5 caulier.gilles 2023-04-09 06:05:35 UTC
Git commit bf659a6a8d28b721d2852644839a98c358257ef5 by Gilles Caulier.
Committed on 09/04/2023 at 06:04.
Pushed by cgilles into branch 'master'.

disable menu icons under MacOS

M  +7    -0    core/app/main/main.cpp
M  +7    -0    core/showfoto/main/main.cpp

https://invent.kde.org/graphics/digikam/commit/bf659a6a8d28b721d2852644839a98c358257ef5
Comment 6 caulier.gilles 2023-04-09 06:47:54 UTC
Fixed : https://i.imgur.com/sDPt8Ra.png