Bug 461718 - Jump to last message/first unread button is being covered by msg action "toolbar"
Summary: Jump to last message/first unread button is being covered by msg action "tool...
Status: RESOLVED FIXED
Alias: None
Product: NeoChat
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Tobias Fella
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-12 08:37 UTC by Gergely HORVÁTH
Modified: 2022-11-17 14:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Covered button (66.99 KB, image/png)
2022-11-12 08:37 UTC, Gergely HORVÁTH
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gergely HORVÁTH 2022-11-12 08:37:27 UTC
Created attachment 153685 [details]
Covered button

I'm not sure about the proper terminology, see attached image for clarity. The round button that can be pressed to jump to the first unread msg, or the last msg if scrolled up in a conversation gets covered by the reply/more action buttons of a msg. It can be pressed, but the pixel hunt is not great for UX.
Comment 1 Gergely HORVÁTH 2022-11-12 08:42:32 UTC
Sry, version number is missing:
```sh
$ pacman -Qs neochat
local/neochat 22.09-1
    A client for matrix, the decentralized communication protocol
```
Comment 2 James Graham 2022-11-12 09:08:10 UTC
This should be mostly dealt with in master by this patch https://invent.kde.org/network/neochat/-/merge_requests/537. However may still occur when the screen is thin. Probably just need to ensure that the jump to latest button always shows over the top.
Comment 3 Gergely HORVÁTH 2022-11-12 11:40:50 UTC
I checked that MR and based on the screenshots, and applying a very very scientific method (put a paper on the screen) I checked, that even in compact mode the reply button does not overlap with the jump to latest button. I'm looking forward to this patch landing in release!
Comment 4 James Graham 2022-11-12 14:27:28 UTC
That's mostly the case however when the window is very narrow (not shown in the mr) the hover buttons go back to their original position. This is by design because there isn't space to indent them but what I'll probably do is make a quick change to ensure that the down button is at the top in these situations.
Comment 5 Bug Janitor Service 2022-11-17 11:41:25 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/628
Comment 6 Tobias Fella 2022-11-17 14:36:03 UTC
Git commit d7f3284aa215f9ca9e5351e0c14a9962ca738639 by Tobias Fella, on behalf of James Graham.
Committed on 17/11/2022 at 14:35.
Pushed by tfella into branch 'master'.

Room Page Up/Down buttons always on top

Ensure that in the small number of cases where the room page up down buttons overlap messages due to the screen being thin that they are always on top

M  +2    -0    src/qml/Page/RoomPage.qml

https://invent.kde.org/network/neochat/commit/d7f3284aa215f9ca9e5351e0c14a9962ca738639