Bug 461559 - Please move Font settings in Ledger settings, as a tab
Summary: Please move Font settings in Ledger settings, as a tab
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: ux-ui (show other bugs)
Version: git (master)
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-07 18:54 UTC by adi.sav
Modified: 2022-11-13 15:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description adi.sav 2022-11-07 18:54:57 UTC
Since the settings at Configure > Fonts only change the fonts in the ledger, they should not be a separate category.
They should be moved as a tab in Ledger settings.

This is from Windows 11.
Comment 1 Ralf Habacker 2022-11-11 07:24:17 UTC
With ticket 460952 another solution was implemented (see https://bugs.kde.org/show_bug.cgi?id=460952#c23), so this ticket can be closed.
Comment 2 Jack 2022-11-11 18:49:18 UTC
I don't think it is the same thing.  The fix for that bug corrects the row height so it is not too short and does not clip the text.  This is asking to move the control for fonts from the General configure tab to the Ledger tab, since it seems to only control fonts in the Ledger.  My question is whether that setting should control fonts other than in the Ledger.  If it should only control the fonts in the Ledger, then this is a valid request (if a wishlist.)  If it should control fonts elsewhere in the program, then that is a different bug, and this one is unnecessary (or could be converted to report what is actually broken.)  I don't know which is the intended/correct behavior.
Comment 3 Jack 2022-11-11 22:12:25 UTC
Sorry - I hadn't noticed the last commit to that bug, which does add the logic so font changes also apply to tags and payees views.
adi.sav - please check if this is really still necessary given those changes.
Comment 4 Thomas Baumgart 2022-11-12 05:51:51 UTC
That's true, but also in those views it only changes the font of the ledger. Like Jack, I don't know what the right solution would be (separate tab as it is right now or move to ledger tab)
Comment 5 Jack 2022-11-12 23:42:50 UTC
Perhaps leave the control where it is, but add some text to the dialog specifying the limitations of where it has an effect.
Comment 6 adi.sav 2022-11-13 09:12:03 UTC
Using build 1707.

@Jack
I confirm that the setting from the Font tab applies to Tags, Payees and Legders.
Indeed, informing the user of the areas affected by the Font settings would be nice.

@Thomas Baumgart
Thank you for the patch.

Given this new commit, it is better to leave the Font settings where they are now :)
I am closing this.
Comment 7 Thomas Baumgart 2022-11-13 15:46:36 UTC
Git commit 00ab3003baeaef601f0c84f38a53d0e5a914def8 by Thomas Baumgart.
Committed on 13/11/2022 at 15:42.
Pushed by tbaumgart into branch 'master'.

Provide details which fonts are controlled by settings

M  +131  -116  kmymoney/dialogs/settings/ksettingsfonts.ui

https://invent.kde.org/office/kmymoney/commit/00ab3003baeaef601f0c84f38a53d0e5a914def8