Bug 461486 - Import Subtitle drops text after comma for *.ass files
Summary: Import Subtitle drops text after comma for *.ass files
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (other bugs)
Version First Reported In: 22.08.2
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: erjiang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-06 06:00 UTC by Jonathan Beekman
Modified: 2022-11-10 06:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
A *.ass subtitle file with commas in the text (1.43 KB, text/x-ssa)
2022-11-06 06:00 UTC, Jonathan Beekman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Beekman 2022-11-06 06:00:19 UTC
Created attachment 153512 [details]
A *.ass subtitle file with commas in the text

SUMMARY
When importing *.ass files, commas in subtitles and any text after the comma will not be imported. 


STEPS TO REPRODUCE
1.  Import the attached file using the "Import Subtitle File..." dialog to an empty project.
2.  Open the attached file in a text editor.
3.  Compare the generated subtitles with the contents of the attached file. 

OBSERVED RESULT
Generated subtitles are missing text after commas.

EXPECTED RESULT
Generated subtitles include any text after a comma.

SOFTWARE/OS VERSIONS
Windows: 22.08.2

ADDITIONAL INFORMATION
See http://www.tcax.org/docs/ass-specs.htm for the *.ass subtitle format specification. While similar to a CSV file, commas are not escaped in the dialogue text.
Comment 1 erjiang 2022-11-07 01:44:39 UTC
Confirmed in latest master (7a31421fe7).
Comment 2 erjiang 2022-11-10 06:43:40 UTC
Git commit fa73c4a5ea9b4ea7306e8edf9fb7a7520cda051b by Eric Jiang.
Committed on 10/11/2022 at 06:34.
Pushed by erjiang into branch 'release/22.12'.

Test ASS/SSA files containing commas

Unit test with sample file containing commas in subtitle dialogue.

A  +20   -0    tests/dataset/subs-with-commas.ass
M  +20   -0    tests/subtitlestest.cpp

https://invent.kde.org/multimedia/kdenlive/commit/fa73c4a5ea9b4ea7306e8edf9fb7a7520cda051b