Bug 461469 - Import file filter not working
Summary: Import file filter not working
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Import-Settings (show other bugs)
Version: 7.9.0
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks: 461495
  Show dependency treegraph
 
Reported: 2022-11-05 19:12 UTC by Nicofo
Modified: 2022-11-06 19:01 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.0.0
Sentry Crash Report:


Attachments
Help menu not working (107.14 KB, image/png)
2022-11-05 19:12 UTC, Nicofo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicofo 2022-11-05 19:12:06 UTC
Created attachment 153498 [details]
Help menu not working

The following setting does not work as expected:
Settings > Configure Digikam > Cameras > Import Filters > (below in 'Always ignore' section) > Ignored file names

Or I don't understand how the file filter is supposed to work:
 - the file names are separated by space I suppose ? (by default there are 2 names separated by a space)
 - can we use regex, ... ?
 - (note: the 'Help' button at the bottom left does not work: see screenshot)

I want to filter all the files ".trashed-xxx.jpg" from my phone (android renames deleted files that way) but I can't manage that:  I tried in the field "Ignored file names":
 - .trashed-*
 - .trashed-.*
without success.
Comment 1 Maik Qualmann 2022-11-05 23:16:11 UTC
These filters exist in the setup but are not implemented in the import tool.
The Help button works without any problems here.
We will not allow RegExp in GUI, we have already discussed this to exhaustion on another bug, why not.

Maik
Comment 2 Maik Qualmann 2022-11-06 12:26:31 UTC
Git commit e5e6df7dce6a50af9107bc840933525e8575a8b1 by Maik Qualmann.
Committed on 06/11/2022 at 12:25.
Pushed by mqualmann into branch 'master'.

implement missing names and extensions import filter
Filters are now immediately applied by setup changes.
FIXED-IN: 8.0.0

M  +11   -1    NEWS
M  +2    -0    core/utilities/import/main/importui.cpp
M  +34   -0    core/utilities/import/widgets/importfilter.cpp
M  +2    -0    core/utilities/import/widgets/importfilter.h
M  +24   -4    core/utilities/import/widgets/importfiltercombobox.cpp
M  +1    -0    core/utilities/import/widgets/importfiltercombobox.h

https://invent.kde.org/graphics/digikam/commit/e5e6df7dce6a50af9107bc840933525e8575a8b1
Comment 3 Maik Qualmann 2022-11-06 12:28:25 UTC
Note: the name filter accepts wildcards (*).

Maik
Comment 4 Nicofo 2022-11-06 13:01:16 UTC
(In reply to Maik Qualmann from comment #3)
> Note: the name filter accepts wildcards (*).
> 
> Maik

Perfect, thank you Maik.

If I have well seen, it is possible to add several ignored names separated by a space. Is it possible to specify that (using a hint / tooltip / or something like that) ? (because it is not obvious that the separator must be a space: could have been a coma, ...)
Comment 5 Maik Qualmann 2022-11-06 19:01:27 UTC
Git commit 2c72163c6f31725f02709238bd668f64b1187aab by Maik Qualmann.
Committed on 06/11/2022 at 19:00.
Pushed by mqualmann into branch 'master'.

add tooltip to ignored names and extensions import filter

M  +4    -0    core/utilities/setup/camera/setupcamera.cpp

https://invent.kde.org/graphics/digikam/commit/2c72163c6f31725f02709238bd668f64b1187aab