Bug 461358 - Visual gap at the top of maximized and tiled windows due to 8a91ef78d5069603369600ca1fc715f782d917fb
Summary: Visual gap at the top of maximized and tiled windows due to 8a91ef78d50696033...
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: window decoration (other bugs)
Version First Reported In: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Oded Arbel
URL:
Keywords: regression
: 461537 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-11-03 12:24 UTC by Christoph Feck
Modified: 2023-01-22 22:20 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.27
Sentry Crash Report:


Attachments
Screenshots showing the problem still exists (21.61 KB, image/png)
2022-12-09 12:55 UTC, Oded Arbel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2022-11-03 12:24:52 UTC
Maximized windows have an unrendered 1 pixel gap topmost row. Probably caused by the outline patches.
Comment 1 Nate Graham 2022-11-04 17:04:47 UTC
Can reproduce. We should probably not draw the outline for maximized or tiled windows--at least not for window edges that touch a screen edge.

Thankfully it's just a visual gap, not an *actual* gap.
Comment 2 Nate Graham 2022-11-07 19:01:24 UTC
*** Bug 461537 has been marked as a duplicate of this bug. ***
Comment 3 Akseli Lahtinen 2022-11-18 16:13:43 UTC
I think I know how to fix this bug, but I have hard time testing it.

I do not know how to enable the edited Breeze decoration on my machine. The earlier iterations I did was through this command:
dbus-run-session kwin_wayland ~/Repositories/kde/usr/bin/systemsettings

This is why I've also missed the bug.
Comment 4 Bug Janitor Service 2022-11-18 18:16:44 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/268
Comment 5 Nate Graham 2022-11-18 21:20:48 UTC
Git commit fbe608b1cd11e1b609f0f251c4d6e494cc52a5d0 by Nate Graham, on behalf of Akseli Lahtinen.
Committed on 18/11/2022 at 21:20.
Pushed by ngraham into branch 'master'.

Fix maximized window gap

This should fix the coordinates when windows are maximized, so it doesn't add
an extra margin, which is used by the outlines. Since outlines are not drawn
when windows are maximized, the area would stay blank.
FIXED-IN: 5.27

M  +4    -1    kdecoration/breezedecoration.cpp

https://invent.kde.org/plasma/breeze/commit/fbe608b1cd11e1b609f0f251c4d6e494cc52a5d0
Comment 6 Oded Arbel 2022-11-23 21:01:12 UTC Comment hidden (spam)
Comment 7 Oded Arbel 2022-11-24 17:33:32 UTC Comment hidden (spam)
Comment 8 Nate Graham 2022-11-24 17:36:20 UTC Comment hidden (spam)
Comment 9 Oded Arbel 2022-11-24 18:17:32 UTC Comment hidden (spam)
Comment 10 Nate Graham 2022-11-29 17:47:39 UTC Comment hidden (spam)
Comment 11 Oded Arbel 2022-11-29 19:17:44 UTC Comment hidden (spam)
Comment 12 Nate Graham 2022-11-29 20:42:20 UTC Comment hidden (spam)
Comment 13 Oded Arbel 2022-12-01 10:41:38 UTC Comment hidden (spam)
Comment 14 Nate Graham 2022-12-01 20:24:25 UTC Comment hidden (spam)
Comment 15 Oded Arbel 2022-12-09 12:55:32 UTC
Created attachment 154454 [details]
Screenshots showing the problem still exists

The problem is still apparent when running Breeze from 5f58691d7454538c09ca81590d95ec26fbe19d6f (which should include the fix that was at fbe608b1cd11e1b609f0f251c4d6e494cc52a5d0 - at least according to https://invent.kde.org/plasma/breeze/-/commits/master).

The screenshot shows 2 crops of the top left corner of dolphin on the same screen - on the left it is "quick tiled top" and on the right side it is maximized. It can be clearly seen that the right side there's a 1 pixel gap at the top that shows the desktop background (which is mostly orange-yellow), and a few more pixels in the corner.

This is on Wayland.
Comment 16 Nate Graham 2023-01-20 15:16:43 UTC
Git commit dc404b0c00930d72487ad2fe5745677b8eec3d1f by Nate Graham, on behalf of Akseli Lahtinen.
Committed on 20/01/2023 at 15:16.
Pushed by ngraham into branch 'master'.

kdecoration: Fix outline gap with fractional scale

There was some old code lying around from when there was only one outline
which was on top of titlebar. This removes all that, which fixes the bug.
FIXED-IN: 5.27

M  +3    -7    kdecoration/breezedecoration.cpp

https://invent.kde.org/plasma/breeze/commit/dc404b0c00930d72487ad2fe5745677b8eec3d1f
Comment 17 Nate Graham 2023-01-20 15:17:28 UTC
Git commit f57c08f13c9fadebea866ff40a27ebdc6c613bd3 by Nate Graham, on behalf of Akseli Lahtinen.
Committed on 20/01/2023 at 15:17.
Pushed by ngraham into branch 'cherry-pick-dc404b0c'.

kdecoration: Fix outline gap with fractional scale

There was some old code lying around from when there was only one outline
which was on top of titlebar. This removes all that, which fixes the bug.
FIXED-IN: 5.27


(cherry picked from commit dc404b0c00930d72487ad2fe5745677b8eec3d1f)

M  +3    -7    kdecoration/breezedecoration.cpp

https://invent.kde.org/plasma/breeze/commit/f57c08f13c9fadebea866ff40a27ebdc6c613bd3
Comment 18 Oded Arbel 2023-01-22 22:20:47 UTC
I can confirm that with the current unstable kwin build I can no longer experience the issue.