Bug 461282 - Add Cuba holidays
Summary: Add Cuba holidays
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kholidays
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-01 10:15 UTC by ]\/[ ]\/[ ]_ 1357
Modified: 2023-02-18 16:12 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ]\/[ ]\/[ ]_ 1357 2022-11-01 10:15:06 UTC
Request to add Cuba holidays

STEPS TO REPRODUCE
1. Configure Digital Clock
2. Check Holidays on Calendar tab
3. Search for Cuba holidays

OBSERVED RESULT
There are no Cuba holidays options

EXPECTED RESULT
There are Cuba holidays options

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.26
KDE Plasma Version: 5.26.0
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.6
Comment 1 Allen Winter 2022-12-17 13:23:52 UTC
Would be very helpful if you could give me a list of holidays you expect to see in a calendar.
I can convert to the Cuba holiday file expected by the software.

Here's a starting point.  It would also be useful to have the Spanish translations:

"Liberation Day"                     public on January 1
"Victory Day"                        public on January 2

"Good Friday"                        public on easter minus 2

"International Workers Day"          public on May 1

"Revolution Anniversary"             public on July 25
"Day of the Rebellion"               public on July 26
"Revolution Anniversary Celebration" public on July 27

"Independence Day"                   public on October 10

"Christmas Day"                      public on December 25

"New Year's Eve"                     public on December 31
Comment 2 ]\/[ ]\/[ ]_ 1357 2022-12-25 04:41:42 UTC
"Liberation Day" January 1
"Victory Day" January 2
"Good Friday" Easter minus 2
"International Workers Day" May 1
"Commemoration of the Assault on Cuartel Moncada" July 25
"National Rebellion Day" July 26
"Commemoration of the Assault on Cuartel Moncada" July 27
"Independence Day" October 10
"Christmas" December 25
"End of the Year" December 31

Also we have

"Mother's Day" second Sunday in May
"Father's Day" third Sunday in June
"Children's Day" third Sunday in July

In Spanish:

"Día de la Liberación"                          January 1
"Día de la Victoria"                            January 2
"Viernes Santo"                                 Easter minus 2
"Día internacional de los trabajadores"         May 1
"Conmemoración del Asalto al Cuartel Moncada"   July 25
"Día de la Rebeldía Nacional"                   July 26
"Conmemoración del Asalto al Cuartel Moncada"   July 27
"Día de la Independencia"                       October 10
"Navidad"                                       December 25
"Fin de año"                                    December 31

Also we have

"Día de las madres"                         second Sunday in May
"Día de los padres"                         third Sunday in June
"Día de los niños"                          third Sunday in July
Comment 3 Bug Janitor Service 2023-02-12 23:44:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kholidays/-/merge_requests/62
Comment 4 Allen Winter 2023-02-18 16:12:18 UTC
Git commit 7d56bb5272a95c2976f5028918650ff1065034f3 by Allen Winter, on behalf of Alois Spitzbart.
Committed on 18/02/2023 at 16:12.
Pushed by winterz into branch 'kf5'.

Kf5 add cuba holidays

Added two files for the holidays of cuba. Based on the dates in [https://bugs.kde.org/show_bug.cgi?id=461282](https://bugs.kde.org/show_bug.cgi?id=461282).

Additional added a parameter in description to get complete output for test.


Here is the output of the tests:

```
QDEBUG : HolidayRegionTest::testRegions()
QDEBUG : HolidayRegionTest::testRegions() This regionCode =  "cu_en"
QDEBUG : HolidayRegionTest::testRegions() Is valid? =  true
QDEBUG : HolidayRegionTest::testRegions() Country code =  "CU"
QDEBUG : HolidayRegionTest::testRegions() Language code =  "en"
QDEBUG : HolidayRegionTest::testRegions() Name =  "Cuba"
QDEBUG : HolidayRegionTest::testRegions() Description =  "State holiday file for Cuba"
QDEBUG : HolidayRegionTest::testRegions()
QDEBUG : HolidayRegionTest::testRegions() Parsing region =  "cu_en"  year =  2023  calendar =  "gregorian"
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-01-01" Duration = 1 Name = "Liberation Day      " Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-01-02" Duration = 1 Name = "Victory Day         " Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-04-07" Duration = 1 Name = "Good Friday         " Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-05-01" Duration = 1 Name = "International Workers Day" Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-05-14" Duration = 1 Name = "Mother's Day        " Category = ("cultural")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-06-18" Duration = 1 Name = "Children's Day      " Category = ("cultural")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-07-16" Duration = 1 Name = "Father's Day        " Category = ("cultural")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-07-25" Duration = 1 Name = "Commemoration of the Assault on Cuartel Moncada" Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-07-26" Duration = 1 Name = "National Rebellion Day" Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-07-27" Duration = 1 Name = "Commemoration of the Assault on Cuartel Moncada" Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-10-10" Duration = 1 Name = "Independence Day    " Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-12-25" Duration = 1 Name = "Christmas           " Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-12-31" Duration = 1 Name = "End of the Year     " Category = ("cultural")
QDEBUG : HolidayRegionTest::testRegions()
QDEBUG : HolidayRegionTest::testRegions()
QDEBUG : HolidayRegionTest::testRegions() This regionCode =  "cu_es"
QDEBUG : HolidayRegionTest::testRegions() Is valid? =  true
QDEBUG : HolidayRegionTest::testRegions() Country code =  "CU"
QDEBUG : HolidayRegionTest::testRegions() Language code =  "es"
QDEBUG : HolidayRegionTest::testRegions() Name =  "Cuba"
QDEBUG : HolidayRegionTest::testRegions() Description =  "Días Feriados de Cuba"
QDEBUG : HolidayRegionTest::testRegions()
QDEBUG : HolidayRegionTest::testRegions() Parsing region =  "cu_es"  year =  2023  calendar =  "gregorian"
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-01-01" Duration = 1 Name = "Día de la Liberación" Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-01-02" Duration = 1 Name = "Día de la Victoria  " Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-04-07" Duration = 1 Name = "Viernes Santo       " Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-05-01" Duration = 1 Name = "Día internacional de los trabajadores" Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-05-14" Duration = 1 Name = "Día de las madres   " Category = ("cultural")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-06-18" Duration = 1 Name = "Día de los padres   " Category = ("cultural")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-07-16" Duration = 1 Name = "Día de los niños    " Category = ("cultural")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-07-25" Duration = 1 Name = "Conmemoración del Asalto al Cuartel Moncada" Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-07-26" Duration = 1 Name = "Día de la Rebeldía Nacional" Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-07-27" Duration = 1 Name = "Conmemoración del Asalto al Cuartel Moncada" Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-10-10" Duration = 1 Name = "Día de la Independencia" Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-12-25" Duration = 1 Name = "Navidad             " Category = ("public")
QDEBUG : HolidayRegionTest::testRegions() Date = "2023-12-31" Duration = 1 Name = "Fin de año          " Category = ("cultural")
QDEBUG : HolidayRegionTest::testRegions()
QDEBUG : HolidayRegionTest::testRegions()
```

M  +1    -1    README.md
M  +2    -0    holidays/holidays.qrc
A  +50   -0    holidays/plan2/holiday_cu_en
A  +50   -0    holidays/plan2/holiday_cu_es

https://invent.kde.org/frameworks/kholidays/commit/7d56bb5272a95c2976f5028918650ff1065034f3