Bug 461162 - Plasma theme highlight effect doesn't appear on hover in WindowHeap-based effects
Summary: Plasma theme highlight effect doesn't appear on hover in WindowHeap-based eff...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-window-management (show other bugs)
Version: 5.26.2
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-29 15:04 UTC by Michal Ziabkowski
Modified: 2024-01-17 22:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.0
Sentry Crash Report:


Attachments
Screencast showing the problem (2.01 MB, video/mp4)
2022-11-01 14:48 UTC, Michal Ziabkowski
Details
Screencast of Present Windows on a clean account (1001.32 KB, video/mp4)
2022-11-04 18:16 UTC, Michal Ziabkowski
Details
Screencast of the Overview effect on a clean account (578.33 KB, video/mp4)
2022-11-04 18:17 UTC, Michal Ziabkowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Ziabkowski 2022-10-29 15:04:33 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

After upgrading from Plasma 5.24 to 5.26, I've noticed that the newly rewritten Present Windows effect has no visual feedback when hovering the cursor over a thumbnail. In the old one the hovered item was enlarged and highlighted, which felt much more organic. 

I've tried editing windowview/qml/main.qml and adding this to the windowThumbnail definition, to no avail:
            HoverHandler{
              onHoveredChanged: {
                  if(hovered){
                      windowThumbnail.scale = 1.2
                  }
                  else{
                      windowThumbnail.scale = 1
                  }
            }

The new effect seems to otherwise work fine, except for this blemish. Are there any plans to restore the old behavior in some form or is this a bug on my end?

STEPS TO REPRODUCE
1.  Activate the Present Windows effect
2.  Hover the mouse cursor over one of the window thumbnails

OBSERVED RESULT

There is no animation for the hovered thumbnail.

EXPECTED RESULT

The hovered thumbnail shows visual feedback.

SOFTWARE/OS VERSIONS
Operating System: Gentoo Linux 2.9
KDE Plasma Version: 5.26.2
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.5
Kernel Version: 5.15.71-gentoo (64-bit)
Graphics Platform: X11
Processors: 12 × AMD Ryzen 5 3600 6-Core Processor
Memory: 23.4 GiB of RAM
Graphics Processor: NVIDIA GeForce GT 1030/PCIe/SSE2
Comment 1 Nate Graham 2022-11-01 14:00:32 UTC
It has a highlight effect that appears behind the window when hovered. Are you not seeing that?
Comment 2 Michal Ziabkowski 2022-11-01 14:47:40 UTC
(In reply to Nate Graham from comment #1)
> It has a highlight effect that appears behind the window when hovered. Are
> you not seeing that?

Yeah, I'm not seeing this at all. Uploading a short screencast for reference.
Comment 3 Michal Ziabkowski 2022-11-01 14:48:08 UTC
Created attachment 153377 [details]
Screencast showing the problem
Comment 4 Nate Graham 2022-11-01 14:53:32 UTC
Thanks. What Plasma theme are you using?
Comment 5 Michal Ziabkowski 2022-11-01 15:41:50 UTC
(In reply to Nate Graham from comment #4)
> Thanks. What Plasma theme are you using?

I'm using a third-party theme called IOTA-Plasma, but for the sake of testing I've just now switched to Breeze and it doesn't seem to make a difference. I'm still not getting the highlight effect.
Comment 6 Nate Graham 2022-11-02 17:15:29 UTC
Do you see a highlight effect on hover for list and grid items in Kickoff, or for thumbnails in the Task Manager tooltips, or for list items in System Tray popups?
Comment 7 Michal Ziabkowski 2022-11-02 18:45:22 UTC
(In reply to Nate Graham from comment #6)
> Do you see a highlight effect on hover for list and grid items in Kickoff,
> or for thumbnails in the Task Manager tooltips, or for list items in System
> Tray popups?

I don't use Kickoff, but the Application Menu. But I do see a hover effect on the pinned apps to the left of the list and on the list items. I also see it for the systray popup and when hovering over task icons. I have the task thumbnails disabled, so I have no tooltips.

What I've tried: switching the Plasma theme, color scheme, window decorations. Nothing helped. Maybe this depends on a kwin effect or a config setting I have disabled?
Comment 8 Nate Graham 2022-11-02 19:10:52 UTC
That's odd. It sounds like the highlight effect exists and is being applied to other things correctly, but not Present Windows.

Can you clear the cache with `rm ~/.cache/*plasma*`, reboot, and try again?

Also is it possible that your local overrides have interfered with this? Can you revert to the distro package version too? Thanks!
Comment 9 Michal Ziabkowski 2022-11-02 20:02:23 UTC
(In reply to Nate Graham from comment #8)
> That's odd. It sounds like the highlight effect exists and is being applied
> to other things correctly, but not Present Windows.
> 
> Can you clear the cache with `rm ~/.cache/*plasma*`, reboot, and try again?
> 
> Also is it possible that your local overrides have interfered with this? Can
> you revert to the distro package version too? Thanks!

Clearing the cache and rebooting didn't fix it.

What do you mean with local overrides? I'm using the Plasma 5.26 packages from the Gentoo official repo. All I did was unmask 5.26, since 5.25 is the current stable version in Gentoo. Should I downgrade to 5.25.5 then?
Comment 10 Nate Graham 2022-11-04 16:18:16 UTC
Oh, I thought from your first comment that you had modified the file locally.

I'm at a loss to explain why this one single feature is missing the typical Plasma theme highlight effect on hover, but it works everywhere else.

Do you see the highlight effect in the Overview effect?
Comment 11 Michal Ziabkowski 2022-11-04 17:58:29 UTC
(In reply to Nate Graham from comment #10)
> Oh, I thought from your first comment that you had modified the file locally.
> 
> I'm at a loss to explain why this one single feature is missing the typical
> Plasma theme highlight effect on hover, but it works everywhere else.
> 
> Do you see the highlight effect in the Overview effect?

I did in fact edit the qml file, but reverted it immediately after noticing it didn't help.

Anyway, the overview effect doesn't have the highlight either.
Comment 12 Michal Ziabkowski 2022-11-04 18:16:06 UTC
Okay, so I tried creating a new user and starting afresh. I don't get the hover effect even on a totally stock Plasma 5.26 config. Attaching screencasts for this and the overview effect.

One thing that is non-standard on my system that should not have any bearing on this is that I'm using evdev instead of libinput for my mouse, since the latter lacked some options I needed. Just thought I'd mention this just to be on the safe side.
Comment 13 Michal Ziabkowski 2022-11-04 18:16:46 UTC
Created attachment 153466 [details]
Screencast of Present Windows on a clean account
Comment 14 Michal Ziabkowski 2022-11-04 18:17:17 UTC
Created attachment 153467 [details]
Screencast of the Overview effect on a clean account
Comment 15 Michal Ziabkowski 2022-11-04 19:56:49 UTC
For what it's worth, changing my mouse back to libinput didn't change anything.
Comment 16 Nate Graham 2022-11-07 18:11:06 UTC
I'm entirely at a loss to explain this. I can't reproduce it, nobody else has reported it, and the manifestation doesn't make sense to me given the code in question. Hopefully someone else can take over.
Comment 17 Nate Graham 2024-01-17 22:35:05 UTC
In Plasma 6, we've moved away from using the Plasma theme highlight effect in the name of performance; now we use a simple rounded rectangle which cannot possibly exhibit the same bug, so I'm calling it fixed in Plasma 6. :)