Bug 461102 - Thunderbolt settings side panel has invisible content for large window sizes
Summary: Thunderbolt settings side panel has invisible content for large window sizes
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_thunderbolt (show other bugs)
Version: 5.26.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-28 09:21 UTC by Vorpal
Modified: 2023-06-18 16:23 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27.6


Attachments
Result on large monitor (104.96 KB, image/png)
2022-10-28 09:21 UTC, Vorpal
Details
Results with small window size (works as expected) (110.16 KB, image/png)
2022-10-28 09:21 UTC, Vorpal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vorpal 2022-10-28 09:21:10 UTC
Created attachment 153255 [details]
Result on large monitor

SUMMARY

When resizing or maximising the Thunderbolt settings to be large, the details in the side panel become invisible. See attached screenshots comparing small and large. I have also uploaded a short video showing what happens when I resize it: https://www.youtube.com/watch?v=pd8xVbrNJ_Q

STEPS TO REPRODUCE
1. Open Thunderbolt settings
2. Click on a paired device to open the side panel.
3. Notice that the text is cut off, how much depend on the size of the settings window, with more cut off the larger the window is.

OBSERVED RESULT
Can't see the text or the "Revoke Trust" button.

EXPECTED RESULT
Layout should be done such that all content is visible.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
(available in About System)
KDE Plasma Version: 5.26.2
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.6

ADDITIONAL INFORMATION
Comment 1 Vorpal 2022-10-28 09:21:40 UTC
Created attachment 153256 [details]
Results with small window size (works as expected)
Comment 2 Keven L. Ates 2023-06-14 15:04:15 UTC
Reviewing this issue, I see the same.  Reducing the screen to the smallest size shows the side content for the selected item.  As the screen is widened, the side content is pushed into "unseen territory" to the right.  Also, the separator bar should be user adjustable / movable.
Comment 3 Nate Graham 2023-06-14 18:32:58 UTC
I could probably fix this easily if I had any Thunderbolt hardware with which to test the page, but alas, I don't.
Comment 4 Daniel Vrátil 2023-06-16 09:46:27 UTC
Nate, there's a fakeserver in the autotests directory that implements the Bolt daemon DBus interface. You can give it some fake Thunderbird device configuration (there's one in the data subdir) and then run the KCM with `KBOLT_FAKE` env var set. The library will then talk to the fake server instead of the real bolt system daemon. This way you should be able to see something in the KCM and interact with it, even if you don't have physical Thunderbolt on your system.

I should say I'd look into it myself, but this is most likely a Kirigami/UI issue which you will be much faster at fixing than myself :)
Comment 5 Nate Graham 2023-06-16 21:19:52 UTC
Yay I got it working! Will fix.
Comment 6 Bug Janitor Service 2023-06-16 21:30:09 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-thunderbolt/-/merge_requests/25
Comment 7 Nate Graham 2023-06-16 21:32:49 UTC
Now that I can hack on the KCM, after that MR is merged, I'll submit another one modernizing its UI to bring it up to date with the latest styling for Plasma 6. That one won't be backportable to 5, of course.

Thanks a lot for writing that fake server. Really nice touch.
Comment 8 Nate Graham 2023-06-18 16:22:59 UTC
Git commit 519c48a78e9e050b8d3c86ea576b3a88a9d3787a by Nate Graham.
Committed on 18/06/2023 at 16:22.
Pushed by ngraham into branch 'master'.

Fix UI with huge window sizes

Using a KCM-within-a-KCM paradigm was not ideal and caused weird layout
glitches. We can fix them all by changing the device list page to be a
plain old Kirigami.ScrollablePage.
FIXED-IN: 5.27.6

M  +2    -2    src/kcm/ui/DeviceList.qml

https://invent.kde.org/plasma/plasma-thunderbolt/-/commit/519c48a78e9e050b8d3c86ea576b3a88a9d3787a
Comment 9 Nate Graham 2023-06-18 16:23:30 UTC
Git commit d8474c7594093b9cb58ea618a1c029425a3327cb by Nate Graham.
Committed on 18/06/2023 at 16:23.
Pushed by ngraham into branch 'Plasma/5.27'.

Fix UI with huge window sizes

Using a KCM-within-a-KCM paradigm was not ideal and caused weird layout
glitches. We can fix them all by changing the device list page to be a
plain old Kirigami.ScrollablePage.
FIXED-IN: 5.27.6


(cherry picked from commit 519c48a78e9e050b8d3c86ea576b3a88a9d3787a)

M  +2    -2    src/kcm/package/contents/ui/DeviceList.qml

https://invent.kde.org/plasma/plasma-thunderbolt/-/commit/d8474c7594093b9cb58ea618a1c029425a3327cb