Bug 461041 - Running with --install-only shows sad face even when installation succeeds
Summary: Running with --install-only shows sad face even when installation succeeds
Status: RESOLVED FIXED
Alias: None
Product: kdesrc-build
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Michael Pyne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-26 23:52 UTC by Natalie Clarius
Modified: 2023-12-16 13:41 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/sdk/kdesrc-build/-/commit/caf913834355d569cb5815b1af1d230c60495721
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Natalie Clarius 2022-10-26 23:52:07 UTC 
SUMMARY
When only running the installation phase, kdesrc-build always gives me a sad face, even when everything was successful. Would be more appropriate I think to show the smiley in that case.

STEPS TO REPRODUCE
1. kdesrc-build --install-only some-module

OBSERVED RESULT
>  Installing.. succeeded (after 1 second)
> :-(

EXPECTED RESULT
> :-)
Comment 1 Nate Graham 2022-10-28 17:41:47 UTC 
lol
Comment 2 Andrew Shark 2023-12-16 13:41:47 UTC 
Git commit caf913834355d569cb5815b1af1d230c60495721 by Andrew Shark.
Committed on 16/12/2023 at 13:50.
Pushed by ashark into branch 'master'.

Fix incorrect fail detection condition in install and uninstall run modes.

M  +8    -8    modules/ksb/Application.pm
M  +2    -3    modules/ksb/Module.pm

https://invent.kde.org/sdk/kdesrc-build/-/commit/caf913834355d569cb5815b1af1d230c60495721