Bug 461022 - Adaptive transparency doesn't work anymore when using Qt scaling on X11
Summary: Adaptive transparency doesn't work anymore when using Qt scaling on X11
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: master
Platform: openSUSE Linux
: NOR normal
Target Milestone: 1.0
Assignee: veggero
URL:
Keywords: regression
Depends on:
Blocks: 356446
  Show dependency tree / graph
 
Reported: 2022-10-26 15:04 UTC by Fushan Wen
Modified: 2022-12-23 21:41 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/commit/cba16a7a9d1ab3a7e159afe008f56b35f99cc8b8
Version Fixed In: 5.27
qydwhotmail: X11+

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Fushan Wen 2022-10-26 15:04:29 UTC 
SUMMARY
After https://invent.kde.org/plasma/plasma-desktop/-/commit/ed0214057e7ae78bedc4486a6344db9459ce5570 , the adaptive transparency feature is completely broken when using Qt scaling and fractional scaling.


STEPS TO REPRODUCE
1. Enable adaptive transparency
2. Maximize/Cancel maximize a window
3. Watch the panel

OBSERVED RESULT
The vertical panel is always translucent, and the horizontal panel is always opaque.

EXPECTED RESULT
Adaptive!

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.26.80
KDE Frameworks Version: 5.100
Qt Version: 5.15.6

ADDITIONAL INFORMATION
Comment 2 Nate Graham 2022-10-26 19:50:31 UTC 
Can reproduce on X11.

Also, a floating panel no longer de-floats when touched by a window or when there are any maximized windows.

Probably the calculation is mixing logical and physical coordinates in a way that works on X11 without Qt scaling, and with Wayland with Qt scaling (where *everything* is scaled), but not X11 with Qt scaling (where some things are scaled and some things are not).

Niccolò, can you investigate? Thanks!
Comment 3 Bug Janitor Service 2022-11-27 10:56:26 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2373
Comment 4 Bug Janitor Service 2022-12-18 10:46:05 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1308
Comment 5 Nate Graham 2022-12-23 21:41:04 UTC 
Git commit cba16a7a9d1ab3a7e159afe008f56b35f99cc8b8 by Nate Graham, on behalf of Fushan Wen.
Committed on 23/12/2022 at 21:34.
Pushed by ngraham into branch 'master'.

desktoppackage: fix adaptive panel on X11 when Qt scaling is enabled

Geometry from TasksModel on X11 does not take devicePixelRatio into
account unlike panel geometry.
FIXED-IN: 5.27

M  +6    -4    desktoppackage/contents/views/Panel.qml

https://invent.kde.org/plasma/plasma-desktop/commit/cba16a7a9d1ab3a7e159afe008f56b35f99cc8b8