Bug 461017 - Link previews on Neochat occupy way more space than needed
Summary: Link previews on Neochat occupy way more space than needed
Status: RESOLVED FIXED
Alias: None
Product: NeoChat
Classification: Applications
Component: General (other bugs)
Version First Reported In: unspecified
Platform: Fedora RPMs Linux
: NOR minor
Target Milestone: ---
Assignee: Tobias Fella
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-26 13:19 UTC by Marc Deop
Modified: 2022-11-14 11:32 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Neochat link preview (23.16 KB, image/png)
2022-10-26 13:19 UTC, Marc Deop
Details
Element link preview (21.18 KB, image/png)
2022-10-26 13:20 UTC, Marc Deop
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Deop 2022-10-26 13:19:33 UTC
Created attachment 153218 [details]
Neochat link preview

SUMMARY

Link previews on Neochat occupy way more space than needed. See attachments in a comparison between Neochat and Element


STEPS TO REPRODUCE
1. Just observe when someone sends a link

OBSERVED RESULT
A URL preview is shown but is way too big

EXPECTED RESULT
A URL preview is shown but on a decent size

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora Linux 36
(available in About System)
KDE Plasma Version: 5.26.1
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.6

ADDITIONAL INFORMATION
Neochat built from commit: 4443b58 (installed from https://copr.fedorainfracloud.org/coprs/xvitaly/matrix/ )
Comment 1 Marc Deop 2022-10-26 13:20:02 UTC
Created attachment 153219 [details]
Element link preview
Comment 2 James Graham 2022-10-28 18:03:11 UTC
I'm struggling to replicate this both in the current release, master and the commit you referenced. The text doesn't have any unnecessary line breaks for me. Is this happening to all links or just the one you posted as the attachment.
Comment 3 Bug Janitor Service 2022-11-12 05:14:47 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Marc Deop 2022-11-12 10:15:31 UTC
(In reply to James Graham from comment #2)
> I'm struggling to replicate this both in the current release, master and the
> commit you referenced. The text doesn't have any unnecessary line breaks for
> me. Is this happening to all links or just the one you posted as the
> attachment.

I've done some more testing and not all link previews are wrong:

- OK:          https://fedoramagazine.org/how-i-customize-fedora-silverblue-and-fedora-kinoite/
- OK:          https://gitlab.com/fedora/ostree/ci-test/-/issues/1 > this one was for rawhide. Will give F36 a try again tomorrow. 
- NOT OK: https://bugs.kde.org/show_bug.cgi?id=461017
- NOT OK: https://copr.fedorainfracloud.org/coprs/g/kdesig/kde/package/plasma-desktop/
- NOT OK: https://copr.fedorainfracloud.org/coprs/g/kdesig/kde/
Comment 5 Jan Bidler 2022-11-12 10:27:54 UTC
Can reproduce on Arch 22.09
Comment 6 Bug Janitor Service 2022-11-12 11:32:52 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/605