Bug 460968 - Incorrect UI description in "show editing tools"
Summary: Incorrect UI description in "show editing tools"
Status: RESOLVED INTENTIONAL
Alias: None
Product: gwenview
Classification: Applications
Component: general (other bugs)
Version First Reported In: 22.08.2
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-25 07:01 UTC by Barnacle
Modified: 2022-10-25 17:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Barnacle 2022-10-25 07:01:55 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
When "show editing tools" is clicked, it should show "hide editing tools" in the UI but the UI is not updated

OBSERVED RESULT
When "show editing tools" is clicked, it shows "show editing tools" in the UI

EXPECTED RESULT
When "show editing tools" is clicked, it should show "hide editing tools" in the UI

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
https://invent.kde.org/graphics/gwenview/-/blob/master/app/mainwindow.cpp#L477 has the code
Comment 1 Nate Graham 2022-10-25 17:13:57 UTC
This button is a checkable toggle button. When you click it, it becomes visually checked. So it's showing "yes, show the editing tools". Same principle as checkable menu items, where we also don't change the text.

We deliberately don't change the text for checkable buttons and menu items because it would confusingly create a double negative.