Bug 460761 - Recent regression Cannot any more reassign faces by dragging them on the left sidebar items
Summary: Recent regression Cannot any more reassign faces by dragging them on the left...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-Workflow (show other bugs)
Version: 7.9.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-20 12:51 UTC by Jens
Modified: 2022-10-20 21:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jens 2022-10-20 12:51:52 UTC
SUMMARY: see $SUBJECT

STEPS TO REPRODUCE
1. Open any "Person" in the left People sidebar.
2. Drag any face thumbnail of that person onto a different "Person" item in the same sidebar.

OBSERVED RESULT
Context menu appears: "Use this as face thumbnail".

EXPECTED RESULT
Context menu expected: "Reassign face from PersonA to PersonB".

This worked in the 2022-10-02 appimage, so it is a recent regression.

SOFTWARE/OS VERSIONS: KDE Neon 20.04, Digikam appimage 64bit 2022-10-16.
Comment 1 Jens 2022-10-20 14:28:18 UTC
Correcetion: this only happens if both faces have the same "base name tag" (but are in different folders).
If the faces have different base name tags, this feature still works.

I did not test this with old Digikam appimages so this may not be a regression. But IMHO still a bug.
Comment 2 Maik Qualmann 2022-10-20 16:41:03 UTC
This is not a bug, it is checked on the name even if they are in different tag paths. With the same name you get the entry to set the thumbnail preview. If the names are different, the assignment. If you want to merge 2 names, use the merge function, it also updates the face regions automatically.

Maik
Comment 3 Jens 2022-10-20 20:06:38 UTC
But why not use the full path? Is there a big performance penalty?

I have many name duplicates - even two full name duplicates, including surnames - in my tag tree.
Reassigning names if I accidentally chose the wrong tag while tagging becomes very difficult this way.
Comment 4 Maik Qualmann 2022-10-20 20:25:21 UTC
digiKam has a long history and many users have submitted their wishes. I seem to remember that a person should be able to follow different tag paths. When storing in the face metadata, a flat list of names is used anyway. For whatever reason. We can pin it to the tag path and see if another bug report is opened.

Maik
Comment 5 Maik Qualmann 2022-10-20 20:59:03 UTC
Git commit 2bfd724d4fe91d7bac504b6f6672f74834230d97 by Maik Qualmann.
Committed on 20/10/2022 at 20:58.
Pushed by mqualmann into branch 'master'.

fully resolve a face tag for drag and drop actions
FIXED-IN: 8.0.0

M  +1    -1    NEWS
M  +24   -3    core/app/dragdrop/tagdragdrop.cpp

https://invent.kde.org/graphics/digikam/commit/2bfd724d4fe91d7bac504b6f6672f74834230d97
Comment 6 Jens 2022-10-20 21:14:41 UTC
Thanks!

But wait ... does that mean that for Digikam, faces "/School/Thomas" and "/Work/Thomas" are actually the same person?

This would explain the terrible face recognition performance I have with certain people ...