Bug 460723 - Thumbnails for RAW files are shown allthough they shouldn't
Summary: Thumbnails for RAW files are shown allthough they shouldn't
Status: RESOLVED FIXED
Alias: None
Product: kio-extras
Classification: Frameworks and Libraries
Component: Thumbnails and previews (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-19 17:51 UTC by Jan Rathmann
Modified: 2024-11-18 09:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 24.12
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Rathmann 2022-10-19 17:51:55 UTC
SUMMARY

In Dolphin and file dialog, thumbnails are generated and displayed for various RAW files (.RW2, .ARW, .DNG) allthough I don't want this and have explicitly unchecked this option in Dolphins preview settings ("RAW files").

This started happening after upgrading to Kubuntu 22.10 with enabled backports PPA (Plasma 5.26.1, Frameworks 5.99).

If I also deselect "Images (GIF, PNG, BMP, ...) as a preview type, this stops displaying thumbnails for RAW files, but also for a lot of other image file types where I actually want to see the thumbnails.

Kind regards, Jan

SOFTWARE/OS VERSIONS
Kubuntu 22.10 + Backports-PPA
KDE Plasma Version: 5.26.1
KDE Frameworks Version: 5.99 
Qt Version: 5.15.5
Comment 1 Jan Rathmann 2022-10-20 16:43:20 UTC
Hypothesis after investigating a bit (I hope it's not totally wrong):

* Recently, the camera RAW images plugin has been added to KImageFormats (source: changelog of frameworks 5.99):
https://invent.kde.org/frameworks/kimageformats/-/commit/eefb8146d360879e85c5136401303a99d7b0c845#1a471716951fdc5029dbe12eb74a4bbfa952c59c

* The "imagethumbnail" preview type in Dolphin seems to feel responsible for _every_ image mimetype ( "image/*" ), see:
https://invent.kde.org/network/kio-extras/-/blob/master/thumbnail/imagethumbnail.json

So in combination with the camera RAW images plugin in place, checking the "Images (GIF, PNG, BMP, ...) " entry in preview settings now implicitly also covers RAW files even though one may have explicitly deselected the "raw image" entry.

Not only raw files are affected: There is e.g. a separate entry for JPEG images in the preview settings. If I deselect it, thumbnails for JPG files are displayed nevertheless when "Images (GIF, PNG, BMP, ...) " is selected. So it effectivly does nothing unless one disables previews for all images.

== Idea ==
Perhaps it would be good solution, if the imagethumbnail preview type would only apply to all image files _not_ covered by separate preview types (BMP, PNG, PCX etc; _not_ JPEG or RAW files)?

== (Horrible) workaround  ==
Deleting the file /usr/lib/x86_64-linux-gnu/qt5/plugins/imageformats/kimg_raw.so will stop new RAW thumbnails being generated (to remove the existing ones, purging ~/.cache/thumbnails should help).
Comment 2 Jan Rathmann 2024-11-08 11:41:30 UTC
Testing again, interestingly it seems this bug (creating thumbnails for RAW files allthough disabled) happens for .RW2 files (Panasonic), but not .ARW files (Sony). So it does not affect all types of RAW images.
Comment 3 Méven 2024-11-17 11:50:50 UTC
Git commit ba14aa0dfe9fdd0e508e64f4aacbdb5dd3eb67fc by Méven Car, on behalf of Jan Rathmann.
Committed on 17/11/2024 at 11:50.
Pushed by meven into branch 'master'.

thumbnails: remove fallback image/* for image thumbnailer 

This prevents image thumbnailer to take over raw images when raw thumbnailer has been disabled.

There is a separate thumbnailer for RAW image files. This fixes the problem that the generic image thumbnailer kicks in for some RAW file types eventhough RAW thumbnailing has been disabled in Dolphin by the user.

M  +1    -2    thumbnail/imagethumbnail.json

https://invent.kde.org/network/kio-extras/-/commit/ba14aa0dfe9fdd0e508e64f4aacbdb5dd3eb67fc