Bug 460641 - Auto-lock parameters in rectangular selection tool settings when user manually inputs values
Summary: Auto-lock parameters in rectangular selection tool settings when user manuall...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Selection (show other bugs)
Version: 5.1.0
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: vanyossi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-18 09:03 UTC by rebuilderster
Modified: 2022-10-28 10:54 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rebuilderster 2022-10-18 09:03:01 UTC
I'd like to see the  parameters (width, height, ratio etc.) in the Rectangular Selection Tool's options docker lock if the user manually enters a value.

Currently, you have to first enter e.g. a desired width, then lock the width, and then draw your selection on canvas. I can't think of a use case where you'd not want to use the value you have input to make a selection, so I think it would make sense to automatically lock a field when the user manually adjusts its value.
Comment 1 vanyossi 2022-10-19 04:02:46 UTC
Makes sense, however what would be the logic to "auto unlock it"? erase the input value?
Comment 2 rebuilderster 2022-10-19 08:33:21 UTC
(In reply to vanyossi from comment #1)
> Makes sense, however what would be the logic to "auto unlock it"? erase the
> input value?

I think just using the lock button should do the trick, is there a need to auto unlock? I think some users might expect clearing the field to be the same as inputing 0 - this only applies to the rounding parameters though, otherwise 0 wouldn't be used in any of the rectangular selection tool options. 

If users are likely to be confused by needing to unlock the field, another option would be to have "modes" for the selection tool, where one is "free" and another is numerically defined and would use this auto lock behaviour. I'm not sure that's really needed, but probably some testing would help find out.
Comment 3 Dmitry Kazakov 2022-10-28 10:54:17 UTC
Git commit 5aa196670a9e7c3a945029950a01a035aab2fc1d by Dmitry Kazakov, on behalf of Ivan Yossi.
Committed on 28/10/2022 at 10:53.
Pushed by dkazakov into branch 'master'.

autolock width, height and ratio

M  +21   -3    libs/ui/tool/kis_rectangle_constraint_widget.cpp
M  +3    -0    libs/ui/tool/kis_rectangle_constraint_widget.h

https://invent.kde.org/graphics/krita/commit/5aa196670a9e7c3a945029950a01a035aab2fc1d