Created attachment 152860 [details] Discover Review Screenshot SUMMARY Discover does not let me create a review. After setting filelight to 5 stars, writing a short title and review it says "insert a name" on the bottom left. There is no text-entry field visible, clicking on "insert a name" doesn't do anything. STEPS TO REPRODUCE 1. Open Discover 2. Click on some app 3. Create review, fill out textboxes OBSERVED RESULT Cannot send review, the review button is greyed out, no extra textbox for entering a username. EXPECTED RESULT Having some way to input the desired username. SOFTWARE/OS VERSIONS Arch Linux, Kernel 6.0.1-arch2-1 KDE Plasma Version: 5.26.0 KDE Frameworks Version: 5.99.0 Qt Version: 5.15.6
I have a feeling I know what this is. We now allow the user so set their own name, but not all backends support this, so the text field for it is only conditionally visible. I bet we're requiring that it has text in it even when it's not visible. I'll investigate and fix it.
Yup, I was right. Fix incoming.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/393
Git commit 8577309cafbc9a07eff1cf7a5bdb25c0ac4056b8 by Aleix Pol Gonzalez, on behalf of Nate Graham. Committed on 18/10/2022 at 00:46. Pushed by ngraham into branch 'master'. Reviews: Don't check for name field being empty when it's not visible Now, under certain circumstances, the name field will not be shown. But the logic for ensuring all review data has been filled out was not taking that into account, so it become impossible to submit a review when the field was invisible because technically it was empty, so it triggered the "Insert a name" condition. This commit fixes that by disabling the name check when the name field is invisible. FIXED-IN: 5.26.1 M +1 -1 discover/qml/ReviewDialog.qml https://invent.kde.org/plasma/discover/commit/8577309cafbc9a07eff1cf7a5bdb25c0ac4056b8
Git commit ec06b73df69edc21f0bab60cd331b7764601af48 by Nate Graham. Committed on 18/10/2022 at 00:56. Pushed by ngraham into branch 'Plasma/5.26'. Reviews: Don't check for name field being empty when it's not visible Now, under certain circumstances, the name field will not be shown. But the logic for ensuring all review data has been filled out was not taking that into account, so it become impossible to submit a review when the field was invisible because technically it was empty, so it triggered the "Insert a name" condition. This commit fixes that by disabling the name check when the name field is invisible. FIXED-IN: 5.26.1 (cherry picked from commit 8577309cafbc9a07eff1cf7a5bdb25c0ac4056b8) M +1 -1 discover/qml/ReviewDialog.qml https://invent.kde.org/plasma/discover/commit/ec06b73df69edc21f0bab60cd331b7764601af48
Wow, thank you very much for the fast fix! You're all doing great work on KDE, love it :)
You're very welcome!