Created attachment 152824 [details] Bottles Library screen SUMMARY I am using bottles app from flatpak (GTK 4 app). This app has several missing icons. According to the developer, this is due to Breeze GTK theme. https://github.com/bottlesdevs/Bottles/issues/1627#issuecomment-1156398604 This includes the tour guide icon (check mark icon) and library icon (heart shaped) STEPS TO REPRODUCE 1. Install bottles through flatpak 2. Launch bottles OBSERVED RESULT Missing Icons symbols EXPECTED RESULT Icons present SOFTWARE/OS VERSIONS Linux/KDE Plasma: Arch Linux (available in About System) KDE Plasma Version: 5.26.0 KDE Frameworks Version: 5.99.0 Qt Version: 5.15.6
It's not a problem in the GTK theme, it's an issue in the *icon* theme, which is a cross-desktop thing and separate from the GTK theme. Unfortunately, despite being ostensibly cross-desktop, GNOME and KDE use different naming conventions for their icons and have different sets of icons, which generally means that you'll get missing icons when you use the Breeze icon theme on GTK apps, or the Adwaita icon theme in KDE apps. It could work to have Breeze fall back to Adwaita when Adwaita is also installed, and have Adwaita fall back to Breeze. That could work.
Is the necessary change here as simple as adding Adwaita to the `Inherits=` key in the `index.theme` files for the Breeze and Breeze Dark icon sets in https://invent.kde.org/frameworks/breeze-icons/ ? If so, would there be any issues if the change is made and a user happens to not have the Adwaita theme? (other than Adwaita only icons being broken like it is now) Otherwise it seems like a simple enough change to make, and I think it would be especially useful for folks on immutable OSes like Fedora Kinoite and/or users using Flatpak apps since modifying the Breeze theme files themselves in those cases is not as straightforward. If it really is just the case of someone needing to make a merge request I'd be happy to give it a try. That said, I just tried running Bottles through Flatpak on my Fedora Kinoite install and I can't find any missing icons (at least not the ones shown in the linked issues below), so I guess the Bottles devs have worked around the issue already, and at the moment I don't know of any other app affected (I gave GNOME Web a quick try and I didn't see any clearly broken icons for example). https://github.com/bottlesdevs/Bottles/issues/1627 https://github.com/bottlesdevs/Bottles/issues/2162 https://github.com/bottlesdevs/Bottles/issues/2265 https://github.com/bottlesdevs/Bottles/issues/2399
> Is the necessary change here as simple as adding Adwaita to the `Inherits=` key in the `index.theme` files > for the Breeze and Breeze Dark icon sets in https://invent.kde.org/frameworks/breeze-icons/ ? If so, would > there be any issues if the change is made and a user happens to not have the Adwaita theme? (other than > Adwaita only icons being broken like it is now) Inheriting a missing icon theme causes no issues. Since GTK3 and GTK4 have the Adwaita icon theme as a dependency, simply inheriting Adwaita should be enough to fix all cases of broken icons in GTK apps (caused by this particular issue). > That said, I just tried running Bottles through Flatpak on my Fedora Kinoite install and I can't find any > missing icons (at least not the ones shown in the linked issues below), so I guess the Bottles devs > have worked around the issue already, and at the moment I don't know of any other app affected (I gave > GNOME Web a quick try and I didn't see any clearly broken icons for example). I don't see any missing icons in Bottles either. A lot of icons do successfully fall back to Adwaita despite the missing inherit, it's only a few that end up breaking and from my experience it only happens with GTK4 apps (maybe libadwaita? non-libadwaita GTK4 apps are pretty rare). Also, Breeze already covers most of Adwaita's common icons, so it's difficult to find broken icons. There are still a few, though. The icon for broken symlinks in Nautilus is broken with Breeze. GNOME Control Center also has a bunch of broken icons. You probably shouldn't be running Control Center in KDE, but it's still a problem for those wishing to use Breeze icons on GNOME.
> I don't see any missing icons in Bottles either. Yes a recent update[https://github.com/bottlesdevs/Bottles/releases/tag/51.0] has replaced the icons with custom ones and they seem to working fine.