Bug 460349 - Large icon in the application menu
Summary: Large icon in the application menu
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: 5.26.0
Platform: Other Linux
: HI normal
Target Milestone: 1.0
Assignee: Nate Graham
URL:
Keywords: regression
: 460536 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-10-13 10:11 UTC by dS810
Modified: 2022-11-13 16:32 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.26.4


Attachments
Application menu (42.72 KB, image/png)
2022-10-13 10:11 UTC, dS810
Details

Note You need to log in before you can comment on or make changes to this bug.
Description dS810 2022-10-13 10:11:16 UTC
Created attachment 152766 [details]
Application menu

Large icon in the application menu (see screenshot)

Operating System: Arch Linux
KDE Plasma Version: 5.26.0
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.6
Kernel Version: 5.19.13-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i5-8350U CPU @ 1.70GHz
Memory: 15.0 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 620
Manufacturer: HP
Product Name: HP EliteBook 830 G5
Comment 1 Nate Graham 2022-10-14 18:56:42 UTC
No idea how this could be possible.
Comment 2 Nate Graham 2022-10-17 19:49:19 UTC
*** Bug 460536 has been marked as a duplicate of this bug. ***
Comment 3 Nate Graham 2022-10-17 19:49:56 UTC
I probably broke this somehow with the normal/compact size toggle I added for 5.26. Will investigate.
Comment 4 Nate Graham 2022-11-13 01:09:57 UTC
https://invent.kde.org/plasma/plasma-desktop/-/blob/master/applets/kickoff/package/contents/ui/KickoffListDelegate.qml#L32

This appears to be happening for non-categories in the category list. I forgot we support that, oops.
Comment 5 Nate Graham 2022-11-13 01:30:09 UTC
Raising to HI priority since this affects the default setup with KHelpCenter in the category list.
Comment 6 Bug Janitor Service 2022-11-13 01:39:15 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1249
Comment 7 Nate Graham 2022-11-13 16:15:17 UTC
Git commit 2c562db400af0bc5ac4d39157df4c69d5bc6e0b3 by Nate Graham.
Committed on 13/11/2022 at 16:14.
Pushed by ngraham into branch 'master'.

applets/kickoff: fix huge icons in category list

Kickoff's category list can have apps in it, and in fact we ship this
way by default, with KHelpCenter below the categories.

A code change in 0868a5ae8154d10ccc7488034bc5b6e458a17968 to add the new
compact list item style altered how icon size is calculated to take into
account the value of `isCategory`. But this is false for category list
items that happen to be apps. As a result, the apps in the category list
inappropriately use the app style and their icons are too big.

To fix this, we should force the smaller icon size and list item style
for apps in the category list, because there's no room to show the
subtitles here.

To make the code clearer, `isCategory` is renamed to
`isCategoryListItem` to indicate its status as communicating that the
item lives in the category list, not whether or not it actually is a
category.
FIXED-IN: 5.26.4

M  +2    -2    applets/kickoff/package/contents/ui/AbstractKickoffItemDelegate.qml
M  +1    -1    applets/kickoff/package/contents/ui/ApplicationsPage.qml
M  +6    -4    applets/kickoff/package/contents/ui/KickoffListDelegate.qml
M  +1    -1    applets/kickoff/package/contents/ui/PlacesPage.qml

https://invent.kde.org/plasma/plasma-desktop/commit/2c562db400af0bc5ac4d39157df4c69d5bc6e0b3
Comment 8 Nate Graham 2022-11-13 16:32:09 UTC
Git commit 1673711dd27eefeea4c636d9c8fc56ee1f6a70fc by Nate Graham.
Committed on 13/11/2022 at 16:31.
Pushed by ngraham into branch 'Plasma/5.26'.

applets/kickoff: fix huge icons in category list

Kickoff's category list can have apps in it, and in fact we ship this
way by default, with KHelpCenter below the categories.

A code change in 0868a5ae8154d10ccc7488034bc5b6e458a17968 to add the new
compact list item style altered how icon size is calculated to take into
account the value of `isCategory`. But this is false for category list
items that happen to be apps. As a result, the apps in the category list
inappropriately use the app style and their icons are too big.

To fix this, we should force the smaller icon size and list item style
for apps in the category list, because there's no room to show the
subtitles here.

To make the code clearer, `isCategory` is renamed to
`isCategoryListItem` to indicate its status as communicating that the
item lives in the category list, not whether or not it actually is a
category.
FIXED-IN: 5.26.4

M  +2    -4    applets/kickoff/package/contents/ui/AbstractKickoffItemDelegate.qml
M  +1    -1    applets/kickoff/package/contents/ui/ApplicationsPage.qml
M  +6    -4    applets/kickoff/package/contents/ui/KickoffListDelegate.qml
M  +1    -1    applets/kickoff/package/contents/ui/PlacesPage.qml

https://invent.kde.org/plasma/plasma-desktop/commit/1673711dd27eefeea4c636d9c8fc56ee1f6a70fc