Bug 460263 - Ekos focuser too small hardcoded max travel in UI
Summary: Ekos focuser too small hardcoded max travel in UI
Status: RESOLVED FIXED
Alias: None
Product: kstars
Classification: Applications
Component: general (other bugs)
Version First Reported In: 3.6.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jasem Mutlaq
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-11 18:59 UTC by Hans Lambermont
Modified: 2022-10-13 07:52 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Note the greyed-out increase Max Travel arrow indicating that this is a UI thing. (15.16 KB, image/png)
2022-10-11 18:59 UTC, Hans Lambermont
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Lambermont 2022-10-11 18:59:39 UTC
Created attachment 152718 [details]
Note the greyed-out increase Max Travel arrow indicating that this is a UI thing.

The focusMaxTravel has a hardcoded maximum set to 100000 in focus.ui
This breaks focusing on an Integra85 which has a max travel of 188500

STEPS TO REPRODUCE
1. Open EKOS focuser tab
2. In there open the Mechanics tab
3. Observe that Max Travel is limited to 100000

OBSERVED RESULT

Max Travel is limited to 100000

EXPECTED RESULT

Max Travel has a much higher limit. Maybe 300000 ?

ADDITIONAL INFORMATION

This bug keeps coming back.
Comment 1 Jasem Mutlaq 2022-10-12 06:41:22 UTC
integra.cpp shows it using wellKnownIntegra85FocusMax which is 188600
Comment 2 Hans Lambermont 2022-10-12 10:27:06 UTC
Yes the driver is right, that is not the problem.
Have a look at the PNG attachment to this bug ticket, that shows the problem is in the GUI. It has a hardcoded maximum of 100000.

In EKOS focus.ui , look at line 1629 :
```
focus.ui
1612             <widget class="QDoubleSpinBox" name="focusMaxTravel">
1613              <property name="sizePolicy">
1614               <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
1615                <horstretch>0</horstretch>
1616                <verstretch>0</verstretch>
1617               </sizepolicy>
1618              </property>
1619              <property name="toolTip">
1620               <string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;Maximum travel in steps before the autofocus process aborts&lt;/p&gt;&lt;/body&gt;&l     t;/html&gt;</string>
1621              </property>
1622              <property name="decimals">
1623               <number>0</number>
1624              </property>
1625              <property name="minimum">
1626               <double>10.000000000000000</double>
1627              </property>
1628              <property name="maximum">
1629               <double>100000.000000000000000</double>
1630              </property>
```
Comment 3 Jasem Mutlaq 2022-10-12 16:41:41 UTC
Git commit 14def4e57688636a2bd2cae680656fc0da70c3be by Jasem Mutlaq.
Committed on 12/10/2022 at 16:41.
Pushed by mutlaqja into branch 'master'.

Respect max travel as set by the focuser.

M  +1    -2    kstars/ekos/focus/focus.cpp

https://invent.kde.org/education/kstars/commit/14def4e57688636a2bd2cae680656fc0da70c3be
Comment 4 Hans Lambermont 2022-10-12 20:43:25 UTC
Fix confirmed. Thanks !
Comment 5 Jasem Mutlaq 2022-10-13 07:52:49 UTC
Git commit 346adf2e6e83126faa3ae5dc60ec4760877d8ef7 by Jasem Mutlaq.
Committed on 13/10/2022 at 07:52.
Pushed by mutlaqja into branch 'stable-3.6.1'.

Respect max travel as set by the focuser.

M  +1    -2    kstars/ekos/focus/focus.cpp

https://invent.kde.org/education/kstars/commit/346adf2e6e83126faa3ae5dc60ec4760877d8ef7