Bug 460220 - Disks tray icon's "Remove all" menu item should be available when there's only one external disk mounted
Summary: Disks tray icon's "Remove all" menu item should be available when there's onl...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Disks & Devices widget (show other bugs)
Version: master
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-11 02:00 UTC by Jin Liu
Modified: 2022-10-11 16:15 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.27
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jin Liu 2022-10-11 02:00:36 UTC
SUMMARY
Currently the "Remove all" item appears only when multiple external disks mounted.  IMHO it should be available even if there's only one disk mounted.
1. I'm getting used to use "Remove all" to unmount all external disks, but often frustrated to not finding it when there's only one disk.
2. Generally, "Close all" actions are available when there's a single thing to close. E.g. "Close all files" in text editors (Kate). "Close all tabs" in web browsers. 

STEPS TO REPRODUCE
1. Mount one external disk
2. Right click on "Disks and devices"

OBSERVED RESULT
No "Remove all" menu item.

EXPECTED RESULT
"Remove all" menu item available.

SOFTWARE/OS 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: master
KDE Frameworks Version: master
Qt Version: 5.15.6
Comment 1 Bug Janitor Service 2022-10-11 02:31:30 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2203
Comment 2 Nate Graham 2022-10-11 16:15:27 UTC
Git commit def130e216c4973bfd92b48adf062eeae50a22ac by Nate Graham, on behalf of Jin Liu.
Committed on 11/10/2022 at 16:15.
Pushed by ngraham into branch 'master'.

applets/devicenotifier: Show "remove all" when only one disk mounted

Currently the "Remove all" item appears only when multiple external disks mounted.
It should be available even if there's only one disk mounted, for the following
reasons:

1. I'm getting used to use "Remove all" to unmount all external disks, but often
   frustrated to not finding it when there's only one disk.
2. Generally, "Close all" actions are available when there's a single thing to
   close. E.g. "Close all files" in text editors (Kate). "Close all tabs" in web
   browsers. 
FIXED-IN: 5.27

M  +1    -1    applets/devicenotifier/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/def130e216c4973bfd92b48adf062eeae50a22ac