Created attachment 152665 [details] pulldown is cutting values If the exporter is changed, the pulldown for the format is cutting valuenames until the dialog is reopen. STEPS TO REPRODUCE 1. open file > export 2. choose another exporter OBSERVED RESULT The values in pulldown for format are cutted. See screenshot. EXPECTED RESULT The valuenames should shown in full
Created attachment 152722 [details] adjust width on change
Created attachment 152723 [details] Always full width
Hi megan i am new to the code site of kde and looking for bugs, which seems to be fixable by me as a beginner. created a fork with the attempt to fix this. https://invent.kde.org/hotzeplotz/ghostwriter/-/compare/master...exportdialog-adjust-dropdown-size?from_project_id=12158 See Attachment "always full width" https://bugs.kde.org/attachment.cgi?id=152723 Read https://develop.kde.org/hig/components/editing/dropdown/. But it's not entirely clear to me what exactly the "design policy" is for such a pulldown. The image shows that the width is longer than the values, but it does not have a length of 100%. Alternatively, the length of the field could be adjusted dynamically with `fileFormatComboBox->setSizeAdjustPolicy(QComboBox::AdjustToContents);` but i guess this is not was the vdg want. See Attachment "adjust width on change" https://bugs.kde.org/attachment.cgi?id=152722 After investigate a bit, i am confused. There are some pulldowns in other projects dialogs with a width of 100%, but i could not found the call of "setSize*" on such comboboxes … Would my attempt be a solution for this? Are you interested in a merge request and could you help me with it? thanks.
Comment on attachment 152722 [details] adjust width on change fileFormatComboBox->setSizeAdjustPolicy(QComboBox::AdjustToContents);
(In reply to Stefan from comment #3) > Hi megan > > i am new to the code site of kde and looking for bugs, which seems to be > fixable by me as a beginner. > > created a fork with the attempt to fix this. > > https://invent.kde.org/hotzeplotz/ghostwriter/-/compare/master... > exportdialog-adjust-dropdown-size?from_project_id=12158 > > See Attachment "always full width" > https://bugs.kde.org/attachment.cgi?id=152723 > > Read https://develop.kde.org/hig/components/editing/dropdown/. But it's not > entirely clear to me what exactly the "design policy" is for such a > pulldown. The image shows that the width is longer than the values, but it > does not have a length of 100%. > > Alternatively, the length of the field could be adjusted dynamically with > `fileFormatComboBox->setSizeAdjustPolicy(QComboBox::AdjustToContents);` but > i guess this is not was the vdg want. > > See Attachment "adjust width on change" > https://bugs.kde.org/attachment.cgi?id=152722 > > After investigate a bit, i am confused. There are some pulldowns in other > projects dialogs with a width of 100%, but i could not found the call of > "setSize*" on such comboboxes … > > Would my attempt be a solution for this? Are you interested in a merge > request and could you help me with it? thanks. Hi Stephan, I think you're on the right track. I recall having to do something similar to the StatisticsIndicator class. Go ahead and put in the merge request, and I will test it on my end to confirm it's working, plus provide any feedback. Thanks for your help!
A possibly relevant merge request was started @ https://invent.kde.org/office/ghostwriter/-/merge_requests/3
Git commit a48044968e7880c8718ff48330222b68785b0a88 by Megan Conkle, on behalf of Stefan Mayer. Committed on 13/10/2022 at 16:34. Pushed by wereturtle into branch 'master'. Adjust size of drop down in export dialog The dropdown list of the export dialog cuts the values if the exporter is changed until the dialog is reopened. This fix stretches both drop down fields to a width of 100%, like other projects do. M +3 -1 src/exportdialog.cpp https://invent.kde.org/office/ghostwriter/commit/a48044968e7880c8718ff48330222b68785b0a88