Bug 459997 - Ctrl+PageUp/PageDown shortcuts navigate up or down twice
Summary: Ctrl+PageUp/PageDown shortcuts navigate up or down twice
Status: RESOLVED FIXED
Alias: None
Product: NeoChat
Classification: Applications
Component: General (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Tobias Fella
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-05 08:39 UTC by Nate Graham
Modified: 2023-02-20 17:18 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2022-10-05 08:39:25 UTC
When using the Ctrl+PageUp and Ctrl+PageDown shortcuts to navigate between sidebar items, each invocation navigates up or down twice, not once.

Interestingly, using Ctrl+Tab and Ctrl+Shift+Tab behave correctly and navigate up or down only once.
Comment 1 Tobias Fella 2022-11-27 15:10:36 UTC
This looks like a Qt bug; the signal we connect to is emitted twice
Comment 2 Bug Janitor Service 2022-11-27 16:00:17 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/676
Comment 3 Bug Janitor Service 2023-02-17 22:19:29 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/807
Comment 4 Tobias Fella 2023-02-20 17:18:31 UTC
Git commit e0f16054fca51590f05c250cec60a234dad3ac9e by Tobias Fella, on behalf of Kevin Wolf.
Committed on 20/02/2023 at 17:07.
Pushed by tfella into branch 'master'.

Fix Ctrl+PgUp/PgDn shortcut for room switching

Before this change, Ctrl+PgUp/PgDown didn't select the next room, but
actually moved two rooms at once because the signal handler was called
twice. I'm not entirely sure why this happens (it might be a bug in a
lower layer?), but as we don't want to handle the same event elsewhere,
accepting the event doesn't feel wrong and it appears to fix the issue.
So let's just do that.

M  +2    -0    src/qml/Page/RoomPage.qml

https://invent.kde.org/network/neochat/commit/e0f16054fca51590f05c250cec60a234dad3ac9e