Created attachment 152543 [details] Backtrace of thread 1 SUMMARY As of 5.1.0, Krita is likely to crash when dragging across patterns in the Fill Layer interface. STEPS TO REPRODUCE 1. Select "Add Fill Layer" 2. Select "Pattern" 3. Click and drag across patterns. OBSERVED RESULT Krita segfaults. EXPECTED RESULT No segfault. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Debian sid KDE Plasma Version: 5.25.5 KDE Frameworks Version: 5.98.0 Qt Version: 5.12.12 (appimage)
As this only starts occuring in 5.1.0, marking as a regression.
Confirming, let's see.
Git commit e93ace6bbbbf546e0782a6c705e9057a87ffb01f by Sharaf Zaman. Committed on 12/10/2022 at 09:19. Pushed by szaman into branch 'master'. Fix nullptr dereference in pattern generator If while dragging we click outside of the window bounds, none of the pattern is selected resulting in: widget()->patternChooser->currentResource() pointing to a nullptr. But with includeHidden flag enabled we can still reference the last selected pattern. So, this seems like a minor error (i.e operating on only "non hidden" resource). M +1 -1 plugins/generators/pattern/kis_wdg_pattern.cpp https://invent.kde.org/graphics/krita/commit/e93ace6bbbbf546e0782a6c705e9057a87ffb01f
Git commit 0aeed4342ddd76141e6255bf3b27a5ec76f6ba76 by Sharaf Zaman. Committed on 24/10/2022 at 04:51. Pushed by szaman into branch 'krita/5.1'. Fix nullptr dereference in pattern generator If while dragging we click outside of the window bounds, none of the pattern is selected resulting in: widget()->patternChooser->currentResource() pointing to a nullptr. But with includeHidden flag enabled we can still reference the last selected pattern. So, this seems like a minor error (i.e operating on only "non hidden" resource). (cherry picked from commit e93ace6bbbbf546e0782a6c705e9057a87ffb01f) M +1 -1 plugins/generators/pattern/kis_wdg_pattern.cpp https://invent.kde.org/graphics/krita/commit/0aeed4342ddd76141e6255bf3b27a5ec76f6ba76