Bug 459885 - Subscriptions section always shows numbers on the podcasts
Summary: Subscriptions section always shows numbers on the podcasts
Status: RESOLVED FIXED
Alias: None
Product: kasts
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: bart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-01 12:22 UTC by tobias
Modified: 2023-07-30 18:59 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tobias 2022-10-01 12:22:59 UTC
SUMMARY
When I click on refresh, new podcasts get added to the lists and they are marked as "new" and also a number of new podcasts is displayed on the picture of the podcast.
I can't seem to unmark them, even when I click on the option.

STEPS TO REPRODUCE
see above

OBSERVED RESULT
see above

EXPECTED RESULT
I expect for the podcasts to be unmarked/not marked as new.

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.25.5
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6
Kernel Version: 5.15.70-1-MANJARO (64-bit)
Graphics Platform: Wayland

ADDITIONAL INFORMATION
-
Comment 1 bart 2022-10-05 08:35:38 UTC
Could you provide some more info on how you tried to unmark the episodes and what exactly failed?  It's not clear to me.

On my side it just works with all the possible ways to unmark them as new.
Comment 2 tobias 2022-10-05 14:10:35 UTC
(In reply to bart from comment #1)
> Could you provide some more info on how you tried to unmark the episodes and
> what exactly failed?  It's not clear to me.
> 
> On my side it just works with all the possible ways to unmark them as new.

I go to the "Subscriptions" Section -> then I click on a Podcast -> click on a specific episode -> click on 'Remove "New" Label'.
The problem is that in the "Subscriptions" Section, there are still numbers shown on the Podcasts (like "7" for example), even though I removed all new labels in that Podcast.
Comment 3 bart 2022-11-16 09:43:52 UTC
(In reply to tobias from comment #2)
> (In reply to bart from comment #1)
> > Could you provide some more info on how you tried to unmark the episodes and
> > what exactly failed?  It's not clear to me.
> > 
> > On my side it just works with all the possible ways to unmark them as new.
> 
> I go to the "Subscriptions" Section -> then I click on a Podcast -> click on
> a specific episode -> click on 'Remove "New" Label'.
> The problem is that in the "Subscriptions" Section, there are still numbers
> shown on the Podcasts (like "7" for example), even though I removed all new
> labels in that Podcast.

Ah, wait, your problem is actually that a number is shown on the podcast in the subscriptions page?  That number refers to the amount of "unplayed episodes", not the amount of "new" episodes.
Does this answer your question?

NB: Marking an episode as played will also remove the "new" label.
Comment 4 tobias 2022-11-17 20:48:50 UTC
> Ah, wait, your problem is actually that a number is shown on the podcast in
> the subscriptions page?  That number refers to the amount of "unplayed
> episodes", not the amount of "new" episodes.
> Does this answer your question?
> 
> NB: Marking an episode as played will also remove the "new" label.

Yes that helps, thx for the explanation, but I would like to request a change of this.
It is a bit irritating, I would expect the number to indicate new episodes and not unplayed episodes.
For unplayed episodes there could be a better solution, like:
- a button that shows all unplayed episodes, 
- or an option that lists them on top 
- or an option that "greys out" all played episodes 
etc.
Comment 5 Harry K 2023-05-11 15:31:35 UTC
I do agree with tobias that it's a bit confusing. I, too, had the impression that the number indicated new episodes. I speculate the reasons for the confusion are the following:

1. When a podcast refreshes and the number changes, that change indicates that new things have been added. The number in this case is not as important. If only an icon appeared with no numbers then - I think - most people would understand this as an addition of something new. 
2. The blue background on the number indicator matches the "NEW" word on the episode list. Personally, it makes me perceive these items linked.

Hope this perspective helps.

Regarding a potential change, my suggestion is another layer/icon that says "NEW EPISODES" or something to that effect. This would not alienate current users who might already understand the current behaviour.
Comment 6 Bug Janitor Service 2023-07-25 09:11:42 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/kasts/-/merge_requests/124
Comment 7 bart 2023-07-26 20:01:45 UTC
I've just implemented sorting (and searching) for the subscription page.  The number in the top right corner will now reflect the number that corresponds to the sort algorithm.
E.g. if one selects "sorting by favorite episodes" then the number will be the number of favorited episodes for each podcast.

Would this solve your issue(s)?
Comment 8 bart 2023-07-27 09:24:06 UTC
Git commit c3ca038af7766f201e5ccfb621befd9fd8388654 by Bart De Vries.
Committed on 27/07/2023 at 11:24.
Pushed by bdevries into branch 'master'.

Implement backend to allow Feed list sort and search

The current list of things to sort on (ascending and descending), includes:
- unplayed episodes
- new episodes
- favorite episodes
- title (alphabetical)
For the first three categories, the value of the sort quantity will be shown
in the upper right corner of the delegate.
Related: bug 471012

M  +2    -0    src/CMakeLists.txt
M  +0    -22   src/datamanager.cpp
M  +0    -2    src/datamanager.h
M  +41   -2    src/feed.cpp
M  +4    -0    src/feed.h
M  +20   -16   src/models/feedsmodel.cpp
M  +5    -0    src/models/feedsmodel.h
M  +135  -7    src/models/feedsproxymodel.cpp
M  +36   -0    src/models/feedsproxymodel.h
M  +4    -3    src/qml/FeedListDelegate.qml
M  +79   -5    src/qml/FeedListPage.qml
M  +12   -8    src/qml/SearchBar.qml
M  +2    -0    src/qml/main.qml

https://invent.kde.org/multimedia/kasts/-/commit/c3ca038af7766f201e5ccfb621befd9fd8388654
Comment 9 bart 2023-07-27 09:25:27 UTC
Git commit 95590dd4e5de15aabe18e7b00bdc1c3a8eeddcbb by Bart De Vries.
Committed on 27/07/2023 at 11:25.
Pushed by bdevries into branch 'release/23.08'.

Implement backend to allow Feed list sort and search

The current list of things to sort on (ascending and descending), includes:
- unplayed episodes
- new episodes
- favorite episodes
- title (alphabetical)
For the first three categories, the value of the sort quantity will be shown
in the upper right corner of the delegate.
Related: bug 471012

M  +2    -0    src/CMakeLists.txt
M  +0    -22   src/datamanager.cpp
M  +0    -2    src/datamanager.h
M  +41   -2    src/feed.cpp
M  +4    -0    src/feed.h
M  +20   -16   src/models/feedsmodel.cpp
M  +5    -0    src/models/feedsmodel.h
M  +135  -7    src/models/feedsproxymodel.cpp
M  +36   -0    src/models/feedsproxymodel.h
M  +4    -3    src/qml/FeedListDelegate.qml
M  +79   -5    src/qml/FeedListPage.qml
M  +12   -8    src/qml/SearchBar.qml
M  +2    -0    src/qml/main.qml

https://invent.kde.org/multimedia/kasts/-/commit/95590dd4e5de15aabe18e7b00bdc1c3a8eeddcbb
Comment 10 tobias 2023-07-30 18:59:00 UTC
(In reply to bart from comment #7)
> I've just implemented sorting (and searching) for the subscription page. 
> The number in the top right corner will now reflect the number that
> corresponds to the sort algorithm.
> E.g. if one selects "sorting by favorite episodes" then the number will be
> the number of favorited episodes for each podcast.
> 
> Would this solve your issue(s)?

Wow, interesting solution.
Yes that solves my issue thank you.