Bug 459853 - KCM: Typing fast may cause rename loop on a device details page
Summary: KCM: Typing fast may cause rename loop on a device details page
Status: RESOLVED FIXED
Alias: None
Product: Bluedevil
Classification: Unmaintained
Component: general (other bugs)
Version First Reported In: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-30 11:53 UTC by ratijas
Modified: 2022-10-02 20:44 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.24
Sentry Crash Report:


Attachments
Bluetooth - rename glitch (549.06 KB, video/mp4)
2022-09-30 11:53 UTC, ratijas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ratijas 2022-09-30 11:53:42 UTC
Created attachment 152515 [details]
Bluetooth - rename glitch

SUMMARY

Name field changes device name as soon as something is typed in. But typing fast may lead to a glitch as shown on attached video: device is being renamed back and forth without end. Closing the System Settings (or at least switching to another KCM) stops the constant renaming.

STEPS TO REPRODUCE
1. Open Bluetooth settings.
2. Click on any device.
3. Type something fast in the name field, like, rollover-fast

OBSERVED RESULT
Device name changed (and synchronizes with e.g. Bluetooth applet) back and forth.

EXPECTED RESULT
Robust and reliable text field behavior.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE: git-master
Qt Version: 5.15.6
Kernel Version: 5.19.9-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-6700HQ CPU @ 2.60GHz
Memory: 31.3 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 970M/PCIe/SSE2
Manufacturer: ASUSTeK COMPUTER INC.
Product Name: G752VT
System Version: 1.0

ADDITIONAL INFORMATION
Wrong signal handler (onTextChanged) on a QCC2.TextField seems to be the prime suspect in this case.
Comment 1 Bug Janitor Service 2022-09-30 12:00:35 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/bluedevil/-/merge_requests/96
Comment 2 ratijas 2022-10-02 20:28:51 UTC
Git commit 5c060102c5356284270d1f6dda2bcdfeb9d26c25 by ivan tkachenko.
Committed on 02/10/2022 at 20:25.
Pushed by ratijas into branch 'master'.

kcm: Port TextField to onTextEdited signal to avoid recursive changes
FIXED-IN: 5.24

M  +1    -1    src/kcm/package/contents/ui/Device.qml

https://invent.kde.org/plasma/bluedevil/commit/5c060102c5356284270d1f6dda2bcdfeb9d26c25
Comment 3 ratijas 2022-10-02 20:30:28 UTC
Git commit 1f4bab80b48f011becc3ac48833f376f922e0db0 by ivan tkachenko.
Committed on 02/10/2022 at 20:30.
Pushed by ratijas into branch 'Plasma/5.26'.

kcm: Port TextField to onTextEdited signal to avoid recursive changes
FIXED-IN: 5.24
(cherry picked from commit 5c060102c5356284270d1f6dda2bcdfeb9d26c25)

M  +1    -1    src/kcm/package/contents/ui/Device.qml

https://invent.kde.org/plasma/bluedevil/commit/1f4bab80b48f011becc3ac48833f376f922e0db0
Comment 4 ratijas 2022-10-02 20:43:33 UTC
Git commit 9a9872da46e144a67f9a4940ed10bf8164229326 by ivan tkachenko.
Committed on 02/10/2022 at 20:43.
Pushed by ratijas into branch 'Plasma/5.25'.

kcm: Port TextField to onTextEdited signal to avoid recursive changes
FIXED-IN: 5.24
(cherry picked from commit 5c060102c5356284270d1f6dda2bcdfeb9d26c25)

M  +1    -1    src/kcm/package/contents/ui/Device.qml

https://invent.kde.org/plasma/bluedevil/commit/9a9872da46e144a67f9a4940ed10bf8164229326
Comment 5 ratijas 2022-10-02 20:44:30 UTC
Git commit f8f66626310a9567fd1d67a769a4ef9f9dfd8c67 by ivan tkachenko.
Committed on 02/10/2022 at 20:44.
Pushed by ratijas into branch 'Plasma/5.24'.

kcm: Port TextField to onTextEdited signal to avoid recursive changes
FIXED-IN: 5.24
(cherry picked from commit 5c060102c5356284270d1f6dda2bcdfeb9d26c25)

M  +1    -1    src/kcm/package/contents/ui/Device.qml

https://invent.kde.org/plasma/bluedevil/commit/f8f66626310a9567fd1d67a769a4ef9f9dfd8c67