Bug 459554 - Audio Spectrum Filter doesn't keyframe any parameter
Summary: Audio Spectrum Filter doesn't keyframe any parameter
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Effects & Transitions (show other bugs)
Version: 22.08.1
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Julius Künzel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-23 07:31 UTC by Phuoc
Modified: 2022-11-10 22:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Effect panel (12.88 KB, image/png)
2022-09-23 07:31 UTC, Phuoc
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Phuoc 2022-09-23 07:31:52 UTC
Created attachment 152359 [details]
Effect panel

SUMMARY
I'm trying the Audio Spectrum Filter effect for the first time.
The effect works as expected. But when I tried to apply different Angles to the keyframes the values weren't saved to the keyframes, e.i. all keyframes have the same values. That happens to other parameters, too.

STEPS TO REPRODUCE
1. Enable the audio mixer.
2. Apply Audio Spectrum Filter to the master control.
3. Add some keyframes into the effect and change the value of the Angle in different keyframes, see attachment.

OBSERVED RESULT
The angle of the spectrum display is changed respectively, but for the entire timeline.

EXPECTED RESULT
The angle of the spectrum display should change from one keyframe to the other

SOFTWARE/OS VERSIONS
Windows: 10
Comment 1 Julius Künzel 2022-10-05 19:54:28 UTC
Thanks for your report!

I can confirm this behaviour. However it seems it is wrong that the UI shows the keyframe widget at all, since the audio spectrum filter does not support keyframes yet. BUT I started to implement this upstream in MLT with https://github.com/mltframework/mlt/pull/827

We can make this available in Kdenlive as soon as we depend on MLT >= 7.10
Comment 2 Veps 2022-10-29 18:45:29 UTC
I just quickly checked on the comment on your git merge request:
> jlskuz commented 26 days ago
> this affects audiolevelgraph, audiosprectrum and audiowaveform

Will this effect the possibility for opacity as well?
    I was about to open a bug report but just realized from the supplied screenshot here that  the "Audio Spectrum Filter" doesn't show "opacity" while the "Audio Level Visualization Filter" (that's what meant by audiolevelgraph?)  actually does -- seems crooked to me!

However I would very much appreciate if this would also support opacity-levels though... :)
Comment 3 Julius Künzel 2022-11-06 23:24:17 UTC
Git commit 7a31421fe73e90a10ec956f043159482ba63a9e0 by Julius Künzel.
Committed on 06/11/2022 at 23:23.
Pushed by jlskuz into branch 'master'.

Audio graph filters are keyframable now

Since MLT 7.10

M  +4    -4    data/effects/audiolevelgraph.xml
M  +6    -6    data/effects/audiospectrum.xml
M  +5    -1    data/effects/audiowaveform.xml

https://invent.kde.org/multimedia/kdenlive/commit/7a31421fe73e90a10ec956f043159482ba63a9e0
Comment 4 Julius Künzel 2022-11-10 22:40:04 UTC
Git commit c34cbacf8a0ad87112294e448fdf20b8e19f6244 by Julius Künzel.
Committed on 10/11/2022 at 22:34.
Pushed by jlskuz into branch 'release/22.12'.

Audio graph filters are keyframable now

Since MLT 7.10
(cherry picked from commit 7a31421fe73e90a10ec956f043159482ba63a9e0)

M  +4    -4    data/effects/audiolevelgraph.xml
M  +6    -6    data/effects/audiospectrum.xml
M  +5    -1    data/effects/audiowaveform.xml

https://invent.kde.org/multimedia/kdenlive/commit/c34cbacf8a0ad87112294e448fdf20b8e19f6244