It happens to me constantly that I change the color and by accident or if I try to do something else click on an empty slot in the palette/swatches panel. Everytime I do this it creates a new swatch there, which I don't want. And than in a reflex I try to undo that with ctrl+Z just to figure out undo didn't work and so I undone something I didn't want to undo, so than I need to redo that again etc... Hope you can imagine that's not fun and after quite a while of using Krita I'm not getting used to this. Most probably because the other graphical software I'm using is not doing that. Please add an undo-level to adding a new swatch to the palette by clicking on an empty slot there!! That would be awesome! STEPS TO REPRODUCE 1. Change the color in the Advanced Color Selector 2. Click on an empty palette/swatches slot 3. See that there is a new swatch added 4. Try to undo this with ctrl+z 5. Find out undo didn't undone this action as the swatch is still there (so you just undone something else) OBSERVED RESULT See above EXPECTED RESULT When hitting ctrl + z after adding a swatch by clicking on an empty palette-slot the new swatch removed from the palette SOFTWARE/OS VERSIONS Windows: 10
Yes, the undo system only works on the image, not on other things in Krita. However, your feature request is a valid one. I cannot promise we can do anything about this anytime soon, though, since it would be complicated to implement an undo stack in the colorset class.
(In reply to Halla Rempt from comment #1) > Yes, the undo system only works on the image, not on other things in Krita. > However, your feature request is a valid one. I cannot promise we can do > anything about this anytime soon, though, since it would be complicated to > implement an undo stack in the colorset class. Thanks for the feedback. Completely understandable. It would be nice, but if it's a lot of work for you guys to change this no worries, than I just get used to it. It's a minor thing. Have a nice day!
I've actually started working on it today... Still no promises of success, though!
And someone on IRC suggested adding a lock button to lock the palette against any edits, and I'm adding that, too.
@halla Rempt You are amazing! Thank you!
Okay, I got it working, technically, but there is some visual weirdness with displaying groups if you undo or redo adding groups.
And now it's lead to me refactoring a hairy bit of tangled-up code, but I'm still working on it!
(In reply to Halla Rempt from comment #7) > And now it's lead to me refactoring a hairy bit of tangled-up code, but I'm > still working on it! Thanks for the updates and your efforts! I'm sure after all the refactoring it's even better and more easy to maintain! ;)
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1617
Still working on this -- it turned out I had to write tests for every level in the palette code since it was rather buggy. So, functionally done in two, three days, then a month of hacking. (Though tbf, I was sick for a couple of weeks again...)
(In reply to Halla Rempt from comment #10) > Still working on this -- it turned out I had to write tests for every level > in the palette code since it was rather buggy. So, functionally done in two, > three days, then a month of hacking. (Though tbf, I was sick for a couple of > weeks again...) I don't envy you and the situation you've seemed to have bumped into, but really appreciate this! Thanks for all the hard work!
Git commit 4f2674db88ae8ef115a3cd302b3ddaf2405751cb by Halla Rempt. Committed on 27/01/2023 at 14:32. Pushed by rempt into branch 'master'. Add undo, redo and lock functionality to the palette docker Each KoColorSet now has its own undo stack. All palette modifying api in KoColorSet now creates an undo command. There are buttons in the palette docker to undo and redo. The ctrl-z/ctrl-shift shortcuts don't work for this undostack, because of focus problems. There is also a lock button that if toggled prevents any modifying api in KoColorSet from being used. The lock status is not stored in any settings or in the resource database, so on restart every palette is unlocked again. Other changes: * it became necessary to refactor KisPaletteModel, KisPaletteView and KisPaletteEditor to not duplicate the state of the KoColorSet * KisSwatchGroup is now always handled through a shared pointer instead of sometimes as a raw pointer and sometimes as a reference * KoColorSetTest now tests the entire modification API. Question: should the undo stack be cleared on saving the palette? M +14 -14 libs/libkis/Palette.cpp M +4 -4 libs/libkis/Palette.h M +1 -1 libs/libkis/PaletteView.cpp M +1 -0 libs/pigment/CMakeLists.txt M +1 -1 libs/pigment/KoColorProfileStorage.cpp M +22 -20 libs/pigment/resources/KisSwatchGroup.cpp M +54 -25 libs/pigment/resources/KisSwatchGroup.h M +712 -200 libs/pigment/resources/KoColorSet.cpp M +115 -35 libs/pigment/resources/KoColorSet.h M +23 -9 libs/pigment/resources/KoColorSet_p.h M +37 -29 libs/pigment/tests/TestKisSwatchGroup.cpp M +449 -0 libs/pigment/tests/TestKoColorSet.cpp M +24 -0 libs/pigment/tests/TestKoColorSet.h M +3 -3 libs/resources/KoResource.cpp M +51 -51 libs/ui/KisPaletteEditor.cpp M +18 -20 libs/ui/KisPaletteEditor.h M +2 -2 libs/ui/dialogs/KisDlgPaletteEditor.cpp M +1 -1 libs/widgets/KisDlgInternalColorSelector.cpp M +9 -12 libs/widgets/KisPaletteComboBox.cpp M +9 -6 libs/widgets/KisPaletteComboBox.h M +22 -33 libs/widgets/KisPaletteDelegate.cpp M +0 -5 libs/widgets/KisPaletteDelegate.h M +80 -115 libs/widgets/KisPaletteModel.cpp M +50 -79 libs/widgets/KisPaletteModel.h M +2 -2 libs/widgets/KoColorSetWidget.cpp M +45 -32 libs/widgets/kis_palette_view.cpp M +7 -3 libs/widgets/kis_palette_view.h M +1 -0 libs/widgets/tests/CMakeLists.txt A +363 -0 libs/widgets/tests/TestKisPaletteModel.cpp [License: GPL(v2.0+)] A +56 -0 libs/widgets/tests/TestKisPaletteModel.h [License: GPL(v2.0+)] M +104 -32 plugins/dockers/palettedocker/palettedocker_dock.cpp M +9 -1 plugins/dockers/palettedocker/palettedocker_dock.h M +77 -38 plugins/dockers/palettedocker/wdgpalettedock.ui M +1 -1 plugins/extensions/layersplit/layersplit.cpp M +4 -4 plugins/extensions/pykrita/sip/krita/Palette.sip M +2 -2 plugins/tools/basictools/kis_tool_colorsampler.cc M +15 -16 plugins/tools/tool_lazybrush/kis_tool_lazy_brush_options_widget.cpp M +1 -4 plugins/tools/tool_lazybrush/kis_tool_lazy_brush_options_widget.h https://invent.kde.org/graphics/krita/commit/4f2674db88ae8ef115a3cd302b3ddaf2405751cb
This only implemented the undo/redo functionality itself, the actual buttons are pending a rewrite of the palette docker itself. See https://phabricator.kde.org/T16123