Bug 459514 - Maximizing and restoring the window makes Overview page inappropriately gain extra empty space below the Application stable
Summary: Maximizing and restoring the window makes Overview page inappropriately gain ...
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (other bugs)
Version First Reported In: 5.25.5
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords: regression
: 460133 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-09-22 07:52 UTC by Riccardo Robecchi
Modified: 2022-10-13 08:48 UTC (History)
5 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-systemmonitor/commit/8cd378dbbc97311b7366f01f94c2c55508d5da99
Version Fixed/Implemented In: 5.26
Sentry Crash Report:

Attachments
Screenshot of the issue (37.86 KB, image/png)
2022-09-22 07:52 UTC, Riccardo Robecchi 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Riccardo Robecchi 2022-09-22 07:52:16 UTC 
Created attachment 152324 [details]
Screenshot of the issue

SUMMARY
Maximising and then restoring the window makes the Overview page scroll way below the amount needed to display all the content, so that a lot of unused and useless white space is displayed if the user scrolls all the way down.

STEPS TO REPRODUCE
1. Maximise window
2. Restore it 

OBSERVED RESULT
The user can scroll to display a lot of white space.

EXPECTED RESULT
The user cannot scroll beyond the last widget.

SOFTWARE/OS VERSIONS
Linux: KDE neon
KDE Plasma Version: 5.25.5
KDE Frameworks Version: 5.97.0
Qt Version: 5.15.5

ADDITIONAL INFORMATION
Comment 1 veggero 2022-09-22 16:45:35 UTC 
Can confirm, best way to reproduce is to set the window the smallest size possible before maximizing
Comment 2 Nate Graham 2022-09-22 21:12:37 UTC 
Can also reproduce.
Comment 3 Arjen Hiemstra 2022-09-28 11:16:03 UTC 
This seems to be a regression caused by the recent changes done to Kirigami's ScrollablePage.
Comment 4 Bug Janitor Service 2022-09-28 11:41:07 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/193
Comment 5 Arjen Hiemstra 2022-09-28 14:14:46 UTC 
Git commit 2b63ea0372c6353cdc08623f480e69fe6a93fad7 by Arjen Hiemstra.
Committed on 28/09/2022 at 11:40.
Pushed by ahiemstra into branch 'master'.

Move DialogLoader to data of ScrollablePage

Otherwise they're considered part of the content and end up causing
problems when resizing.

M  +33   -32   src/page/EditablePage.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/2b63ea0372c6353cdc08623f480e69fe6a93fad7
Comment 6 Arjen Hiemstra 2022-09-28 14:15:23 UTC 
Git commit 8cd378dbbc97311b7366f01f94c2c55508d5da99 by Arjen Hiemstra.
Committed on 28/09/2022 at 14:15.
Pushed by ahiemstra into branch 'Plasma/5.26'.

Move DialogLoader to data of ScrollablePage

Otherwise they're considered part of the content and end up causing
problems when resizing.


(cherry picked from commit 2b63ea0372c6353cdc08623f480e69fe6a93fad7)

M  +33   -32   src/page/EditablePage.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/8cd378dbbc97311b7366f01f94c2c55508d5da99
Comment 7 Arjen Hiemstra 2022-10-13 08:48:55 UTC 
*** Bug 460133 has been marked as a duplicate of this bug. ***