Bug 459495 - Remove layer restrictions for "ten scripts"
Summary: Remove layer restrictions for "ten scripts"
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: 5.1.1
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Halla Rempt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-21 19:17 UTC by thetwo
Modified: 2022-09-22 08:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description thetwo 2022-09-21 19:17:00 UTC
On some layer types, the plug-in cannot run scripts, and the buttons are grayed out.

( clone layer, file layer, vector layer, group layer and transform mask)

I think its judging condition is whether the layer has editable pixels.Ideally, 10 scripts shouldn’t judge if a script is executable or not as some script may not be related to layer management…

KA thread:https://krita-artists.org/t/how-to-delete-all-empty-layers/48197/6
Comment 1 Halla Rempt 2022-09-21 19:19:45 UTC
Ah, good point. It also shows how dangerous it is to fix bugs in relatively obscure features, because since the moment I fixed a bug there, requests have been coming in :-) But there is no reason for these actions to be limited to anything.

If I'm not totally tired out by today's outing to visit a faraway friend, I might look into it tomorrow. There are more improvements I've seen out on k-a.
Comment 2 Halla Rempt 2022-09-22 08:21:07 UTC
Git commit 7ebab909c185563c0556fadb339f73abf5837a89 by Halla Rempt.
Committed on 22/09/2022 at 08:21.
Pushed by rempt into branch 'master'.

Allow scripts to be executed when there is no paintable layer

Note that scripts that don't check whether there's a paintable
layer when they need it will give problems: that's up to the
user to handle.

M  +10   -10   plugins/python/tenscripts/tenscripts.action

https://invent.kde.org/graphics/krita/commit/7ebab909c185563c0556fadb339f73abf5837a89
Comment 3 Halla Rempt 2022-09-22 08:21:24 UTC
Git commit c6445e10b9241ca542bac6cab97ca08ad04c4d67 by Halla Rempt.
Committed on 22/09/2022 at 08:21.
Pushed by rempt into branch 'krita/5.1'.

Allow scripts to be executed when there is no paintable layer

Note that scripts that don't check whether there's a paintable
layer when they need it will give problems: that's up to the
user to handle.
(cherry picked from commit c3c57b4a7ec350acdd07ed9e532e6c20d87d21e9)

M  +10   -10   plugins/python/tenscripts/tenscripts.action

https://invent.kde.org/graphics/krita/commit/c6445e10b9241ca542bac6cab97ca08ad04c4d67