Bug 459353 - Application: Subtitle Composer (subtitlecomposer), signal: Segmentation fault
Summary: Application: Subtitle Composer (subtitlecomposer), signal: Segmentation fault
Status: RESOLVED WORKSFORME
Alias: None
Product: subtitlecomposer
Classification: Applications
Component: general (other bugs)
Version First Reported In: git-master
Platform: Slackware Linux
: NOR crash
Target Milestone: ---
Assignee: Mladen Milinkovic, Max
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-18 21:03 UTC by carlos
Modified: 2022-10-21 05:02 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
attachment (5.58 KB, text/plain)
2022-09-18 21:03 UTC, carlos
Details
crash with Fixed possible null pointer deref patch (4.69 KB, text/plain)
2022-09-19 17:33 UTC, carlos
Details
miscellaneous info (5.92 KB, text/plain)
2022-09-19 19:23 UTC, carlos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description carlos 2022-09-18 21:03:11 UTC
Created attachment 152196 [details]
attachment

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Run subtitlecomposer
2. open video
3. crash

OBSERVED RESULT

crash

EXPECTED RESULT

no crash

SOFTWARE/OS VERSIONS

Operating System: Slackware 15.0
KDE Plasma Version: 5.25.5
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6
Kernel Version: 5.19.9 (64-bit)
Comment 1 Mladen Milinkovic, Max 2022-09-18 21:24:03 UTC
Have pushed a possible fix to git master: https://invent.kde.org/multimedia/subtitlecomposer/-/commit/c94e4dc1362b9ac03cddb9def913ea6728875fe2

Can you check if that resolves the crash?

If it still crashes:
Can you tell me the version of installed libavformat (ffmpeg library) on your system?
Do you know if subtitlecomposer was compiled against the same version?
Comment 2 carlos 2022-09-19 17:21:35 UTC
(In reply to Mladen Milinkovic, Max from comment #1)
> Have pushed a possible fix to git master:
> https://invent.kde.org/multimedia/subtitlecomposer/-/commit/
> c94e4dc1362b9ac03cddb9def913ea6728875fe2
> 
> Can you check if that resolves the crash?
> 
> If it still crashes:
> Can you tell me the version of installed libavformat (ffmpeg library) on
> your system?


> Do you know if subtitlecomposer was compiled against the same version?

(In reply to Mladen Milinkovic, Max from comment #1)
> Have pushed a possible fix to git master:
> https://invent.kde.org/multimedia/subtitlecomposer/-/commit/
> c94e4dc1362b9ac03cddb9def913ea6728875fe2
> 
> Can you check if that resolves the crash?
> 

Nope. I'll attach the last (I think) crash.
I'm having a set of  unrelated problems with the package manager scripts
that threw the whole system off. 
call trace:
? panic 
? rest_init 
? ret_from_fork
kernel ofset: disabled
~~~[ end Kernel [ panic ­not syncing: no working init found

> If it still crashes:
> Can you tell me the version of installed libavformat (ffmpeg library) on
> your system?

As I don't have the info handy now, the crash happened with the following 
ffmpeg 

1adfd28f9e (HEAD -> master, origin/master, origin/HEAD) qsvenc_{hevc,h264}: add scenario option

and tit also happened with he latest ffmpeg ( hours before submitting the crash 

1af0051977 (HEAD -> master, origin/master, origin/HEAD) doc/filters: add speechnorm examples


> Do you know if subtitlecomposer was compiled against the same version?

It was compiled against both ffmpeg as noted above
Comment 3 carlos 2022-09-19 17:33:17 UTC
Created attachment 152232 [details]
crash with Fixed possible null pointer deref patch
Comment 4 carlos 2022-09-19 19:23:00 UTC
Created attachment 152234 [details]
miscellaneous info

according to ffmpeg refs, the version would be 5.1
Comment 5 Mladen Milinkovic, Max 2022-09-19 21:45:27 UTC
(In reply to carlos from comment #4)
> As I don't have the info handy now, the crash happened with the following 
> ffmpeg 
> 
> 1adfd28f9e (HEAD -> master, origin/master, origin/HEAD) qsvenc_{hevc,h264}:
> add scenario option
> 
> and tit also happened with he latest ffmpeg ( hours before submitting the
> crash 
> 
> 1af0051977 (HEAD -> master, origin/master, origin/HEAD) doc/filters: add
> speechnorm examples

Could you please try using stable ffmpeg release? You're using ffmpeg builds from master branch if I'm not wrong.

Just to confirm, the crash happens with any/every video file?

I don't see anything wrong with SC code where it's crashing, it wasn't checking for nullptr there, but that was fixed.
Comment 6 carlos 2022-09-21 20:25:57 UTC
(In reply to Mladen Milinkovic, Max from comment #5)
> (In reply to carlos from comment #4)
> > As I don't have the info handy now, the crash happened with the following 
> > ffmpeg 
> > 
> > 1adfd28f9e (HEAD -> master, origin/master, origin/HEAD) qsvenc_{hevc,h264}:
> > add scenario option
> > 
> > and tit also happened with he latest ffmpeg ( hours before submitting the
> > crash 
> > 
> > 1af0051977 (HEAD -> master, origin/master, origin/HEAD) doc/filters: add
> > speechnorm examples
> 
> Could you please try using stable ffmpeg release? You're using ffmpeg builds
> from master branch if I'm not wrong.
> 

I agree. 

But, out of curiosity, would it normally happen (crashing while opening a video file) 
if you were to  compile it against an ffmpeg devel release? 

In other words, I just can't recall if it was compiled at first  against an unstable vs stable
release. That part I can't remember. But I've always, usually, run the latest ffmpeg and never
had an issue. 

> Just to confirm, the crash happens with any/every video file?
> 

Yes. 

> I don't see anything wrong with SC code where it's crashing, it wasn't
> checking for nullptr there, but that was fixed.

Thanks Max. Unfortunately there's so much I can do on that particular system
with the segmentation fault,  from this point forward,
as I pointed out earlier with the unrelated issue from the kernel etc. I'm pretty much stuck there.

As a side note: there was an error while trying to configure  porcketsphinx with ` autoreconfig -ivf` 
as outlined on the wiki building from sources.

I ended up cmake -S . -B build per the README documentation 

```
Building CXX object src/speechplugins/pocketsphinx/CMakeFiles/pocketsphinxasr.dir/pocketsphinxconfig.cpp.o
[100%] Linking CXX shared module pocketsphinxasr.so

/usr/bin/ld: CMakeFiles/pocketsphinxasr.dir/pocketsphinxplugin.cpp.o: in function `SubtitleComposer::PocketSphinxPlugin::init()':
subtitlecomposer/src/subtitlecomposer/src/speechplugins/pocketsphinx/pocketsphinxplugin.cpp:34: undefined reference to `cmd_ln_init'
/usr/bin/ld: subtitlecomposer/src/subtitlecomposer/src/speechplugins/pocketsphinx/pocketsphinxplugin.cpp:60: undefined reference to `cmd_ln_int_r'
/usr/bin/ld: CMakeFiles/pocketsphinxasr.dir/pocketsphinxplugin.cpp.o: in function `SubtitleComposer::PocketSphinxPlugin::cleanup()':
subtitlecomposer/src/subtitlecomposer/src/speechplugins/pocketsphinx/pocketsphinxplugin.cpp:79: undefined reference to `cmd_ln_free_r'
collect2: error: ld returned 1 exit status
make[2]: *** [src/speechplugins/pocketsphinx/CMakeFiles/pocketsphinxasr.dir/build.make:181: src/speechplugins/pocketsphinx/pocketsphinxasr.so] Error 1
make[1]: *** [CMakeFiles/Makefile2:722: src/speechplugins/pocketsphinx/CMakeFiles/pocketsphinxasr.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
```

All in all, you're probably correct. ffmpeg may have been the culprit when composer was compiled
on that system recently, as opposed to a year or so ago when… perhaps ffmpeg was the stable release.
Comment 7 Mladen Milinkovic, Max 2022-09-21 22:54:12 UTC
(In reply to carlos from comment #6)
> But, out of curiosity, would it normally happen (crashing while opening a
> video file) 
> if you were to  compile it against an ffmpeg devel release? 
Normally it would not happen, but It's possible that bug was introduced on ffmpeg's development (master) branch, and it still wasn't noticed.
I didn't try compiling SC yet against ffmpeg's master branch, so I'm not sure.
Will try that myself ASAP

> As a side note: there was an error while trying to configure  porcketsphinx
> with ` autoreconfig -ivf` 
> as outlined on the wiki building from sources.
> 
> I ended up cmake -S . -B build per the README documentation 
The build instructions wiki page needs an update, but pocketsphinx is pretty broken right now so you can:
1. use an older pocketsphinx (version 5prealpha) and sphinxbase
2. use pocketsphinx e1bd6621 and apply patches from here: https://build.opensuse.org/package/show/home:maxrd2/pocketsphinx (sphinxbase is included with pocketsphinx since 5.0.0)
3. do not use pocketsphinx
Comment 8 Bug Janitor Service 2022-10-06 04:51:18 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 9 Bug Janitor Service 2022-10-21 05:02:21 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!