Bug 459261 - Changing the keyboard shortcut for panning/pan tool doesn't work and throws issues
Summary: Changing the keyboard shortcut for panning/pan tool doesn't work and throws i...
Status: RESOLVED NOT A BUG
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 5.1.1
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-17 09:14 UTC by Maarten
Modified: 2022-09-17 09:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
ctrl+space is only connected to the 'pan tool', but still it does something else and the pan tool is still controlled by the space bar (19.43 KB, image/jpeg)
2022-09-17 09:14 UTC, Maarten
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maarten 2022-09-17 09:14:03 UTC
Created attachment 152143 [details]
ctrl+space is only connected to the 'pan tool', but still it does something else and the pan tool is still controlled by the space bar

Changing keyboard shortcut for PANNING the canvas doesn't work and does strange things.

STEPS TO REPRODUCE
1. Settings --> Configure Krita -->Keyboard shortcuts
2. Change the keyboard shortcut for 'Pan Tool' to 'Ctrl+Space'
3. Click OK
4. Keep SPACE pressed and LMB-drag the canvas --> the keyboard shortcut is still just SPACE, while it should be CTRL+SPACE as we've just changed that. Ctrl+Space shows some zoom tool.
5. Restart Krita
6. Keep SPACE pressed and LMB-drag the canvas --> still doesn't work with Ctrl+Space

7. Settings --> Configure Krita -->Keyboard shortcuts 
8. Search for 'Space' --> nothing similar to 'panning' is connected to this shortcut anymore (I have SPACE connected to 'Play / Pause animation' and that's why I need to change the shortcut for panning)
9. Search for 'Ctrl+Space' --> 'Ctrl+Space' is only connected to the Pan tool, just as we like it. So there is no conflict with another tool and neither it's connected to some zoom-tool.

OBSERVED RESULT
See above.

EXPECTED RESULT
- When settings `ctrl+space` to the pan tool panning should not be controlled by just hitting space bar anymore. Also ctrl+space should not trigger some zoom-tool, but do the panning of the canvas, as that's the keyboard shortcut we set it to

WHY
This is important, because I, like lots of animators / motion designers, are used to start/stop animations with the spacebar. So when setting the spacebar to play/stop it should not handle panning anymore as that's conflicting in the workflow.

SOFTWARE/OS VERSIONS
Windows: 10

ADDITIONAL INFORMATION
Great to see the 5.1.1 version fixed the long wait at startup! Very nice! And keep up the great work
Comment 1 Maarten 2022-09-17 09:29:20 UTC
Ah, I think I misunderstood this keyboard shortcut entry.
I see now when hitting Ctrl+Space it IS infact switching to the PAN TOOL, but it's not the pan tool what I'm after to do with that shortcut, but PANNING, what is normally done with hitting the Spacebar.

It's starting to look like the SPACEBAR to pan-behaviour (and the ctrl+Space behaviour to zoom in/out) are hard coded.

This isn't only causing conflicts now when using space and ctrl+space as keystrokes for other things, but this way it doesn't seem to be possible to change these keyboard shortcuts for panning and zooming to other key strokes.

If that's the case guess this issue is more of a feature request (although still a conflict) to make the keyboard shortcuts for panning and zooming configurable so we can use the Spacebar shortcut for 'play/stop' instead. As that's a pretty common stroke to start and stop animation in animation tools.

So please, make the keystrokes for panning and zooming the canvas configurable!
Comment 2 Wojtek Trybus 2022-09-17 09:33:32 UTC
Hi and thanks for such a detailed explanation if your problem. In fact it's not really a bug, but a common confusion related to canvas inputs.

Keyboard shortcuts are only related to one-time actions like setting something. Those longer actions that include pen input like zooming and panning are specified in settings>configure krita>canvas inputs.

You need to remove it there first - pan tool action is only responsible for changing current tool to pan tool. Canvas input for panning does not switch to the tool, but changes how the mouse press is interpreted - it temporarily pans instead of drawing.

This is a technical limitation, as keyboard shortcuts are a provided solution, while canvas inputs had to be written from scratch by the devs, as these were not possible in this generic solution for app programmers.

Some day there may be a common system for both of these, but probably not in the nearest future
Comment 3 Maarten 2022-09-17 09:42:16 UTC
(In reply to Wojtek Trybus from comment #2)
> Keyboard shortcuts are only related to one-time actions like setting
> something. Those longer actions that include pen input like zooming and
> panning are specified in settings>configure krita>canvas inputs.

You guys are amazing. Completely understandable it's built this way and for this use case perfect as it is. Just changed it in the canvas inputs and now it works as expected! This made my day as now I can use spacebar in all animation software used here!

Thanks for the quick response and all your hard work and have a nice day!