Bug 459177 - Push and pop pages as needed; don't start with all of them on the stack
Summary: Push and pop pages as needed; don't start with all of them on the stack
Status: RESOLVED FIXED
Alias: None
Product: Welcome Center
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-15 19:06 UTC by Nate Graham
Modified: 2023-01-18 19:03 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-welcome/commit/0a746928dbb1fcb75d9f7d3799c998c41da413cf
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2022-09-15 19:06:46 UTC 
This would save some memory and let us get rid of a hack on the Networks page to stop playing the animation when the page is visible and the current page
Comment 1 Oliver Beard 2023-01-17 15:55:49 UTC 
If I understand correctly, this would use pageStack.insertPage() rather than pushing to initialPages?
Comment 2 Nate Graham 2023-01-17 16:07:56 UTC 
Yeah, if that works.
Comment 3 Oliver Beard 2023-01-18 19:03:52 UTC 
Git commit 0a746928dbb1fcb75d9f7d3799c998c41da413cf by Oliver Beard.
Committed on 17/01/2023 at 16:34.
Pushed by ngraham into branch 'master'.

main: Remove initialPages and use push to pageStack instead

M  +13   -28   src/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-welcome/commit/0a746928dbb1fcb75d9f7d3799c998c41da413cf