Bug 459052 - In slideshow wallpaper configuration page, tooltips for elided list items doesn't appear
Summary: In slideshow wallpaper configuration page, tooltips for elided list items doe...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Image & Slideshow wallpaper plugins (show other bugs)
Version: 5.25.5
Platform: Neon Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-13 10:51 UTC by Oded Arbel
Modified: 2022-09-14 20:54 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.26
Sentry Crash Report:


Attachments
Screenshot showing the problem (104.86 KB, image/png)
2022-09-13 10:52 UTC, Oded Arbel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oded Arbel 2022-09-13 10:51:26 UTC
SUMMARY

The configuration dialog for the wallpaper plugin "slideshow" - in its default size that you get when you RMB the desktop and choose "Configure desktop & wallpaper" - is too narrow to have both image samples and a readable folder list

If the folder list contains things from the user's home folder, you can't see anything of the path, except (possibly) the user's home dir path. It would be workable if there was a tooltip to show the full path, but there ain't one

STEPS TO REPRODUCE
1. RMB the desktop wallpaper.
2. Choose "Configure destkop & wallpaper".
3. Select "Slideshow" for the wallpaper plugin.
4. Add a folder under your home directory to the folder list

OBSERVED RESULT
The folder list attempts to show the path to the new folder, but it can only show the start up to the user's name. There's no way to see where that entry is pointing to (other than clicking the "open folder" button to start a new Dolphin instance)

EXPECTED RESULT
There should be enough space to understand relatively short paths under the home dir (for example, mine is `/home/odeda/.local/share/wallpapers`).

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
KDE Plasma Version: 5.25.80
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.5

ADDITIONAL INFORMATION

I can think of a few ways to improve on this issue (all non-exclusive - its possible to do all):
1. As mentioned above, have  tooltip to allow users to easily discover the full path. This should be implemented regardless of other solutions as it will help with arbitrarily long paths that there is otherwise no way to present.
2. Shrink the displayed path to user's folders by replacing "/home/user-id" with "~" - this shorthand should be familiar to most users (and if it isn't, its one more way to help familiarize them with it). Or a house icon - like in Dolphin's places bar, I don't mind either.
3. Make the default size wider.
4. Do something with the folder entry display - I understand that its meant to show the folder name in bold and the path up to that folder (but excluding) as "additional information", but it doesn't work well if you have many "wallpaper" named folders all over the place. Maybe there's something else that can be done?
Comment 1 Oded Arbel 2022-09-13 10:52:44 UTC
Created attachment 152021 [details]
Screenshot showing the problem

This screenshot was generated when configuring a vertical screen. I've noticed later that on a horizontal screen the configuration dialog seems to be a bit wider, so instead of showing just "/home/odeda/...", it shows "/home/odeda/.loc..." - which is probably still not good enough.
Comment 2 Nate Graham 2022-09-13 19:06:21 UTC
The width required to display all text without elision depends on the length of the text and the size of the window; the window being resizable is good enough IMO.

There is actually supposed to be a tooltip though. Seems like it's not working anymore, though. I'll investigate.
Comment 3 Fushan Wen 2022-09-14 11:40:58 UTC
Not a regression. The tooltip was not added from the beginning.
Comment 4 Bug Janitor Service 2022-09-14 11:41:43 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kdeclarative/-/merge_requests/147
Comment 5 Nate Graham 2022-09-14 14:14:50 UTC
This bug report was about the list of wallpaper folders, not the grid view.
Comment 6 Fushan Wen 2022-09-14 14:19:50 UTC
So unfortunately I fixed an non-existing bug again
Comment 7 Nate Graham 2022-09-14 14:29:49 UTC
Well it's good to fix that too. :)
Comment 8 Fushan Wen 2022-09-14 14:57:35 UTC
Git commit 6767dc3f8746b4adadf71c8f6ff38892af1f7cdf by Fushan Wen.
Committed on 14/09/2022 at 14:57.
Pushed by fusionfuture into branch 'master'.

GridDelegate: show tooltip when `toolTip` is empty and title/caption is elided

Even if the `toolTip` property is empty, there should be a way to show the
full title and the full caption.

M  +7    -2    src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

https://invent.kde.org/frameworks/kdeclarative/commit/6767dc3f8746b4adadf71c8f6ff38892af1f7cdf
Comment 9 Nate Graham 2022-09-14 20:54:59 UTC
Git commit fe9f66496337fe8d77cb177fe223261140f4baa5 by Nate Graham.
Committed on 14/09/2022 at 20:52.
Pushed by ngraham into branch 'master'.

wallpapers/slideshowpackage: fix tooltip so it actually appears

We had disabled hover on the list item, so it would never become
visible. In addition, its visibility condition was wrong as we only want
it to become visible for list items that have elided text.
FIXED-IN: 5.26

M  +6    -3    wallpapers/image/slideshowpackage/contents/ui/SlideshowComponent.qml

https://invent.kde.org/plasma/plasma-workspace/commit/fe9f66496337fe8d77cb177fe223261140f4baa5