Bug 458843 - dialog-information icon is not displayed in notifications
Summary: dialog-information icon is not displayed in notifications
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (other bugs)
Version First Reported In: 5.25.5
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-07 16:14 UTC by Sadi
Modified: 2022-09-10 21:40 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.26
Sentry Crash Report:


Attachments
Screenshot of "dialog-*" icons in KDialogs (48.11 KB, image/jpeg)
2022-09-07 16:14 UTC, Sadi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sadi 2022-09-07 16:14:41 UTC
Created attachment 151892 [details]
Screenshot of "dialog-*" icons in KDialogs

SUMMARY
***
I've just noticed that dialog-information icon is not displayed in kdialog passivepopups while all the others in that icon set "dialog-*.svg" are displayed as expected.
***

STEPS TO REPRODUCE
Enter these commands in a terminal window:
kdialog --icon "dialog-error" --title "dialog-error icon" --passivepopup "Displayed" &
kdialog --icon "dialog-information" --title "dialog-information icon" --passivepopup "<b>NOT Displayed</b>" &
kdialog --icon "dialog-positive" --title "dialog-positive icon" --passivepopup "Displayed" &
kdialog --icon "dialog-question" --title "dialog-question icon" --passivepopup "Displayed" &
kdialog --icon "dialog-warning" --title "dialog-warning icon" --passivepopup "Displayed" &
kdialog --title "Test" --msgbox "dialog-information icon is displayed"

OBSERVED RESULT
All those icons are displayed in kdialog passivepopups with only one exception: dialog-information.
However, it is displayed in kdialog msgbox irrespective of icon option there.

EXPECTED RESULT
The icon "dialog-information" should be displayed in kdialog passivepopups as well.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.25
KDE Plasma Version: 5.25.5
KDE Frameworks Version: 5.97.0
Qt Version: 5.15.5
Comment 1 Nicolas Fella 2022-09-08 11:39:22 UTC
This isn't caused by the icon theme.

The reason this particular icon is not displayed is that Plasma explicitly does not show this icon in notifications: https://invent.kde.org/plasma/plasma-workspace/-/blob/master/applets/notifications/package/contents/ui/NotificationItem.qml#L291
Comment 2 Nate Graham 2022-09-09 04:31:50 UTC
Seems like we're outsmarting ourselves here lol
Comment 3 Bug Janitor Service 2022-09-09 20:56:15 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2097
Comment 4 Nate Graham 2022-09-10 21:40:44 UTC
Git commit f9a1b9566ecef1998bee73a08a740bb90c0bf4a3 by Nate Graham.
Committed on 10/09/2022 at 21:27.
Pushed by ngraham into branch 'master'.

applets/notifications: stop suppressing dialog-information icon

This will feel weird and random to the user, especially if they or one
of their apps deliberately uses that icon and then it unexpectedly isn't
displayed. This check feels too magical and unpredictable; let's remove
it to simplify things.
FIXED-IN: 5.26

M  +1    -2    applets/notifications/package/contents/ui/NotificationItem.qml

https://invent.kde.org/plasma/plasma-workspace/commit/f9a1b9566ecef1998bee73a08a740bb90c0bf4a3