Bug 458817 - "Accent color from wallpaper" feature periodically stops updating when the wallpaper changes
Summary: "Accent color from wallpaper" feature periodically stops updating when the wa...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_colors (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-09-06 21:01 UTC by Nate Graham
Modified: 2022-10-04 16:33 UTC (History)
5 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/kde-gtk-config/commit/d5c646f151d1ac7e3fc7c5ff9178b000321a9ab6
Version Fixed In: 5.26
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2022-09-06 21:01:05 UTC 
Everything KDE from git master on top of Fedora 36

STEPS TO REPRODUCE
1. Use "Accent color from wallpaper" in the Colors KCM
2. Set up a slideshow wallpaper
3. Wait a while

OBSERVED RESULT
After a certain number of changed wallpapers, the accent color stops updating.

EXPECTED RESULT
The accent color always keeps updating no matter how many times the wallpaper has changed

ADDITIONAL INFORMATION
Regression from Plasma 5.25; only started happening semi-recently in git master (AKA future Plasma 5.26).
Comment 1 Fushan Wen 2022-09-07 00:28:12 UTC 

*** This bug has been marked as a duplicate of bug 458430 ***
Comment 2 Fushan Wen 2022-09-20 16:14:22 UTC 
https://invent.kde.org/frameworks/kded/-/merge_requests/25 This may help
Comment 3 Bug Janitor Service 2022-10-01 06:03:23 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kde-gtk-config/-/merge_requests/47
Comment 4 Fushan Wen 2022-10-04 16:24:48 UTC 
Git commit 3c2437815920856608a27361fe1da03e763742a5 by Fushan Wen.
Committed on 04/10/2022 at 15:41.
Pushed by fusionfuture into branch 'master'.

kded: properly delete factory to fix file descriptor leak

Not unloading the plugin loader will cause file descriptor leaks in
kded, and when fd limit is reached, accent color can't be updated
anymore because updating accent color requires writing to kdeglobals.
This fixes the leak and also fixes the accent color bug.
Related: bug 458430, bug 459870
FIXED-IN: 5.26

M  +5    -5    kded/kwin_bridge/dummydecorationbridge.cpp
M  +2    -1    kded/kwin_bridge/dummydecorationbridge.h

https://invent.kde.org/plasma/kde-gtk-config/commit/3c2437815920856608a27361fe1da03e763742a5
Comment 5 Fushan Wen 2022-10-04 16:33:07 UTC 
Git commit d5c646f151d1ac7e3fc7c5ff9178b000321a9ab6 by Fushan Wen.
Committed on 04/10/2022 at 16:33.
Pushed by fusionfuture into branch 'Plasma/5.26'.

kded: properly delete factory to fix file descriptor leak

Not unloading the plugin loader will cause file descriptor leaks in
kded, and when fd limit is reached, accent color can't be updated
anymore because updating accent color requires writing to kdeglobals.
This fixes the leak and also fixes the accent color bug.
Related: bug 458430, bug 459870
FIXED-IN: 5.26


(cherry picked from commit 3c2437815920856608a27361fe1da03e763742a5)

M  +5    -5    kded/kwin_bridge/dummydecorationbridge.cpp
M  +2    -1    kded/kwin_bridge/dummydecorationbridge.h

https://invent.kde.org/plasma/kde-gtk-config/commit/d5c646f151d1ac7e3fc7c5ff9178b000321a9ab6