Bug 458742 - No left padding before wifi checkbox
Summary: No left padding before wifi checkbox
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Networks widget (other bugs)
Version First Reported In: master
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-05 13:35 UTC by gudvinr+kde
Modified: 2024-12-23 18:25 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.26.1
Sentry Crash Report:


Attachments
network applet header (28.08 KB, image/png)
2022-09-05 13:35 UTC, gudvinr+kde
Details
pm header (44.58 KB, image/png)
2022-09-05 13:35 UTC, gudvinr+kde
Details
bluetooth header (35.42 KB, image/png)
2022-09-05 13:35 UTC, gudvinr+kde
Details
fonts (30.41 KB, image/png)
2022-09-09 08:08 UTC, gudvinr+kde
Details
5.26 bluetooth (9.34 KB, image/png)
2022-10-14 16:08 UTC, gudvinr+kde
Details
5.26 network (7.89 KB, image/png)
2022-10-14 16:09 UTC, gudvinr+kde
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gudvinr+kde 2022-09-05 13:35:17 UTC
Created attachment 151832 [details]
network applet header

SUMMARY

Header for networks applet pop-up menu doesn't have padding.

It looks bad and becomes even more noticeable when you compare that to bluetooth or power management applets.

Screenshots in attachment.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.25.4
KDE Frameworks Version: 5.97.0
Qt Version: 5.15.5
Graphics Platform: Wayland
Comment 1 gudvinr+kde 2022-09-05 13:35:37 UTC
Created attachment 151833 [details]
pm header
Comment 2 gudvinr+kde 2022-09-05 13:35:59 UTC
Created attachment 151834 [details]
bluetooth header
Comment 3 Nate Graham 2022-09-09 03:42:39 UTC
Looking at these screenshots, it seems like there is something wrong with the scaling configuration on your system that is causing the issue. Please report:
- Whether you're using X11 or Wayland
- The scale factor you've set in System Settings > Display & Monitor, of any
- Your font DPI, and whether you've manually changed it from the default value
- Your font sizes, if you've changes them from any default values
- Your icon sizes, if you've changes them from any default values.

If you don't mind, please refrain from filing any other similar bug reports about bad paddings until we've established how your system is set up, because it's quite possible you're using an incompatible set of settings that is causing the issue here, such that correcting it will  fix the issue everywhere else you're seeing it, too.
Comment 4 gudvinr+kde 2022-09-09 08:08:32 UTC
Created attachment 151945 [details]
fonts
Comment 5 gudvinr+kde 2022-09-09 08:09:37 UTC
(In reply to Nate Graham from comment #3)
> - Whether you're using X11 or Wayland
> - The scale factor you've set in System Settings > Display & Monitor, of any
> - Your font DPI, and whether you've manually changed it from the default
> value
> - Your font sizes, if you've changes them from any default values
> - Your icon sizes, if you've changes them from any default values.

- Wayland (that is standard item that's copied from system info btw)
- None changed, 100% for both monitors
- 120, default was 96 I believe
- In attachment
- Toolbar, Main toolbar - 22; Small icons - 16; Panel - 48; Dialogues - 32. Not sure if I changed those
Comment 6 Nate Graham 2022-09-09 18:10:01 UTC
Are you using an NVIDIA GPU?

Also please scale the system using the scaling slider in System Settings > Display Monitor. Using the "font fonts DPI" setting to scale the UI is not supported and is known to produce issues exactly like this one.
Comment 7 gudvinr+kde 2022-09-09 19:01:42 UTC
(In reply to Nate Graham from comment #6)
> Are you using an NVIDIA GPU?

AMD (Polaris architecture)

> Also please scale the system using the scaling slider in System Settings >
> Display Monitor. Using the "font fonts DPI" setting to scale the UI is not
> supported and is known to produce issues exactly like this one.

I can't do that because of bug 449993. DPI scaling is the only way that works decently at least until 5.26 lands.
Comment 8 Nate Graham 2022-09-09 19:19:08 UTC
Then I'm afraid you'll have to live with this issue, as well as all other similar instances of odd paddings, margins, and icon sizes.
Comment 9 gudvinr+kde 2022-09-09 19:44:27 UTC
So choice is either to have ugly apps or blurry apps. That's rather bad
Comment 10 Nate Graham 2022-09-09 19:47:06 UTC
Well KDE apps all look sharp; the only apps that were blurry were 3rd-party ones that aren't yet Wayland-native (which is pretty embarrassing at this point; it's close to the end of 2022!). And that's already been fixed for Plasma 5.26 anyway. Using unsupported methods of accomplish your goals often come with drawbacks; it's just something you have to be willing to accept when you go looking for workarounds to the problems you encounter.
Comment 11 gudvinr+kde 2022-09-09 20:44:25 UTC
KDE doesn't provide all apps in the world. Since you use Linux yourself you must understand how sparse ecosystem is which makes it tremendously hard to support apps to make them work on every desktop environment.

You can't blame 3rd parties for that. Those 3rd parties have their 3rd parties that they depend on too. And they actually trying.
I mentioned PrusaSlicer in the issue you linked and they investigated issues with Wayland in wxWidgets, made quality MVE and filed an issue.
What else should they do? Fix framework themselves?

There's Blender that also doesn't support Wayland. What should I do? Fix it myself too?

Well, you can blame but that's not cool to be completely honest. I can make same argument that KDE doesn't do a good job at supporting my environment where I want to use feature that KDE system settings provide me. If it isn't supported method then don't put it in settings. It's almost end of 2022, it should've been fixed a long before that. 

Or when KDE Connect freezes system and this bug isn't being fixed for several years already. Or when Dolphin pollutes system with .directory files and it is also not fixed.
I can complain all day about stuff where KDE sucks but it won't solve anything, isn't it?

Anyway, I didn't plan on being salty but you sound very ignorant about Wayland situation in real world if your main point is that KDE apps work, and that's ghetto apps that don't support it are the issue.
Comment 12 Nate Graham 2022-09-09 20:49:03 UTC
KDE has *already* worked around 3rd-party apps' failure to become Wayland-native by letting them use their pre-existing X11 hidpi support on Wayland in Plasma 5.26

And yes, we should remove the "Force Fonts DPI" setting from System Settings. We actually did for a time, but people complained about just this issue, so we were nice and added it back. Now that we allow XWayland apps to use their pre-existing X11 hidpi support on Wayland, we can probably safely remove it again.
Comment 13 gudvinr+kde 2022-09-09 21:00:49 UTC
I am aware of that (and I actually mentioned this exact issue before you did). But first of all, we don't live in a future where 5.26 already out which won't happen for at least a month.

And as I said, I don't mind this not being a bug and I'd rather have proper per-screen scaling than this hack if everything else works fine. But if it were also layout bug and not just DPI scale issue (which is not completely unreasonable thing to assume considering that similar widgets look fine) it could've been fixed in point release of 5.25.

But you are being unnecessarily rude (well, at least it sounds rude considering limited ability of written text to transfer emotional context) towards 3rd parties and users. They do move towards Wayland support and KDE also isn't really perfect in that regard too and still evolves.
Comment 14 Nate Graham 2022-09-09 21:47:31 UTC
I'm sorry if I'm coming off as grumpy. I probably am a bit grumpy, and am not managing my emotions properly. I apologize for that.

It's just that this is a source of major frustration for me as a bug triager and developer. We in KDE try to be nice and offer customization opportunities so that people can self-satisfy, but when they do so, it never looks as good as if the customization wasn't needed because everything worked property out of the box... and also, the customization reduces the urgency for the 3rd-party apps being worked around to get their houses in order and adopt new technologies.

Scaling in particular is a nightmare because there are no fewer than six ways to adjust the size of things if you find that they don't look right to you, each with their own drawbacks:

1. Global scaling slider in System Settings
2. Force Font DPI spinbox in System Settings
3. Adjustable font size in System Settings (because lots--but not all--UI controls resize themselves in proportion to the font size)
4. Adjustable icon size in System Settings
5. Adjustable icon sizes in various individual KDE apps (e.g. Dolphin and Gwenview main view, Places Panel sidebar, etc)
6. Whole-app scaling systems (e.g. scaling slider in Telegram, whole UI responsive to Ctrl+plus and Ctrl+minus in electron apps)

Every time we try to make the overall scaling experience easier to use and better out of the box by getting rid of one of these settings, we get tons of complaints that people were using it to work around such-and-such issue in a 3rd-party app, or in a core technology like XWayland--it's always something that's outside of KDE's control! But when we keep these settings available, it's impossible to ensure that our own software looks right because there are so many ways a user can combine the settings that they can't all possibly be tested for to make sure they don't conflict and produce bad results. So when you use any of these settings except the first one (which is the recommended one), you're kind of on your own.

That was probably too much information, but hopefully it helps to fill in the context a bit. :)
Comment 15 gudvinr+kde 2022-10-14 16:08:09 UTC
Nate, I updated to plasma 5.26 and now I am trying to use display scaling and I disabled DPI scale.

But issue is still there. Padding on left side is still less than in bluetooth widget and header height also different.
Comment 16 gudvinr+kde 2022-10-14 16:08:40 UTC
Created attachment 152817 [details]
5.26 bluetooth
Comment 17 gudvinr+kde 2022-10-14 16:09:16 UTC
Created attachment 152818 [details]
5.26 network
Comment 18 Nate Graham 2022-10-14 16:20:10 UTC
I can reproduce that. Fixing momentarily.
Comment 19 Nate Graham 2022-10-14 16:24:07 UTC
Git commit 0ba7effb983005c235fd56563d0bdc5d567bf704 by Nate Graham.
Committed on 14/10/2022 at 16:23.
Pushed by ngraham into branch 'master'.

applet: add missing left padding on toolbar

Other plasmoids with checkboxes on their toolbars do this, so let's do
it here too both to preserve consistency, and also because it looks
better.
FIXED-IN; 5.26.1

M  +1    -0    applet/contents/ui/PopupDialog.qml

https://invent.kde.org/plasma/plasma-nm/commit/0ba7effb983005c235fd56563d0bdc5d567bf704
Comment 20 Nate Graham 2022-10-14 16:24:53 UTC
Git commit ceaa5891f5414d084d8dfa12aa0991860619fe2e by Nate Graham.
Committed on 14/10/2022 at 16:24.
Pushed by ngraham into branch 'Plasma/5.26'.

applet: add missing left padding on toolbar

Other plasmoids with checkboxes on their toolbars do this, so let's do
it here too both to preserve consistency, and also because it looks
better.
FIXED-IN; 5.26.1

(cherry picked from commit 0ba7effb983005c235fd56563d0bdc5d567bf704)

M  +1    -0    applet/contents/ui/PopupDialog.qml

https://invent.kde.org/plasma/plasma-nm/commit/ceaa5891f5414d084d8dfa12aa0991860619fe2e
Comment 21 gudvinr+kde 2022-10-14 16:34:00 UTC
(In reply to Nate Graham from comment #18)
> I can reproduce that. Fixing momentarily.

Thank you for this immediate fix :)
Comment 22 Nate Graham 2022-10-14 16:35:16 UTC
You're welcome, and thank you for putting up with my grumpiness which was apparently over something that was just wrong!
Comment 23 Ben Cooksley 2024-12-23 18:25:45 UTC
Bulk transfer as requested in T17796