Bug 458674 - New Day/Night filter: Activating and deactivating it makes loading progress bar overlap text
Summary: New Day/Night filter: Activating and deactivating it makes loading progress b...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_nightcolor (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-03 21:37 UTC by guimarcalsilva
Modified: 2022-09-06 15:13 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.26
Sentry Crash Report:


Attachments
Loading indicator overlaps text (82.30 KB, image/png)
2022-09-03 21:37 UTC, guimarcalsilva
Details
Loading when the filter is disabled (23.40 KB, image/png)
2022-09-03 21:44 UTC, guimarcalsilva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description guimarcalsilva 2022-09-03 21:37:24 UTC
Created attachment 151807 [details]
Loading indicator overlaps text

SUMMARY

After https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2055 got merged, with the setting 'Sunset and Sunrise at Current Location' enabled, enabling 'Activate blue light filter', waiting for your location info to get loaded, and disabling it makes the loading progress bar overlap the text that says when the colors will change. (See attached screenshot). 

STEPS TO REPRODUCE
1. Open the Night Color settings page
2. Activate blue light filter and wait for the text saying when the colors will change to come up
3. Disable the filter

OBSERVED RESULT

The loading progress bar overlaps the text (see attached screenshot)

EXPECTED RESULT

Since it already loaded the information it needed, it should probably not show a new loading indicator after you disable the filter.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.25.80
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.5
Kernel Version: 5.15.0-46-generic (64-bit)
Graphics Platform: Wayland
Processors: 6 × Intel® Core™ i5-9400F CPU @ 2.90GHz
Memory: 7,7 GiB of RAM
Graphics Processor: Radeon RX 570 Series

ADDITIONAL INFORMATION

Neon Unstable with the latest updates as of September 3rd 2022.
Comment 1 guimarcalsilva 2022-09-03 21:43:58 UTC
I should also add that when you first load the KCM with the 'Activate blue light filter' checkbox disabled, it starts with the 'Locating..." loading indicator, but it only shows the text with the time the filter will be applied when you enable the effect. Maybe the indicator should only show up in the brief period when the effect is enabled and it's loading your GPS information, otherwise, it will stay there indefinitely.
Comment 2 guimarcalsilva 2022-09-03 21:44:24 UTC
Created attachment 151808 [details]
Loading when the filter is disabled
Comment 3 Bug Janitor Service 2022-09-03 23:41:39 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2077
Comment 4 Nate Graham 2022-09-06 15:11:18 UTC
Git commit 3bcc1847e89e6c58777a12e31378ab1c7e441b63 by Nate Graham, on behalf of Natalie Clarius.
Committed on 06/09/2022 at 14:57.
Pushed by ngraham into branch 'master'.

kcms/nightcolor: don't show location loading placeholder when deactivated

M  +1    -1    kcms/nightcolor/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/3bcc1847e89e6c58777a12e31378ab1c7e441b63