Bug 458614 - Multiline text is displayed incorrectly in avatar chooser
Summary: Multiline text is displayed incorrectly in avatar chooser
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_users (other bugs)
Version First Reported In: 5.25.4
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-01 20:13 UTC by Martin
Modified: 2022-09-06 04:57 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.24.7
Sentry Crash Report:


Attachments
avatar_file_chooser (51.89 KB, image/png)
2022-09-01 20:13 UTC, Martin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin 2022-09-01 20:13:33 UTC
Created attachment 151772 [details]
avatar_file_chooser

SUMMARY
In System Settings -> Users when you want to change the avatar, the text below the file browser button has 2 lines if your language is Spanish for example, and is not displayed correctly.


STEPS TO REPRODUCE
1. Enter System Settings -> Users
2. Click in the avatar image

OBSERVED RESULT
Text below the file browser button is multiline and is not displayed correctly

EXPECTED RESULT
The text is displayed correctly, inside the button

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20220829
KDE Plasma Version: 5.25.4
KDE Frameworks Version: 5.97.0
Qt Version: 5.15.5

ADDITIONAL INFORMATION
Comment 1 Bug Janitor Service 2022-09-02 21:41:33 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2072
Comment 2 Nate Graham 2022-09-05 20:27:32 UTC
Git commit 0dad5f0789c8eb5e4fa893622fdc550898488779 by Nate Graham.
Committed on 05/09/2022 at 20:12.
Pushed by ngraham into branch 'master'.

kcms/users: don't let "Choose File…" text overflow

When using a language that's wordier than English and this label becomes
a two-line string, currently the layout breaks and the string overflows
because the Label item that draws it has no maximum height and elision
mode set.

This commit fixes that by setting them accordingly, and also using a
standard icon size for the icon so that there's actually enough room for
two lines of text.
FIXED-IN: 5.24.7

M  +27   -17   kcms/users/package/contents/ui/UserDetailsPage.qml

https://invent.kde.org/plasma/plasma-workspace/commit/0dad5f0789c8eb5e4fa893622fdc550898488779
Comment 3 Nate Graham 2022-09-05 21:18:13 UTC
Git commit d99460b343b51a0b47c1cc204afda342632951af by Nate Graham.
Committed on 05/09/2022 at 21:18.
Pushed by ngraham into branch 'cherry-pick-0dad5f07'.

kcms/users: don't let "Choose File…" text overflow

When using a language that's wordier than English and this label becomes
a two-line string, currently the layout breaks and the string overflows
because the Label item that draws it has no maximum height and elision
mode set.

This commit fixes that by setting them accordingly, and also using a
standard icon size for the icon so that there's actually enough room for
two lines of text.
FIXED-IN: 5.24.7


(cherry picked from commit 0dad5f0789c8eb5e4fa893622fdc550898488779)

M  +27   -17   kcms/users/package/contents/ui/UserDetailsPage.qml

https://invent.kde.org/plasma/plasma-workspace/commit/d99460b343b51a0b47c1cc204afda342632951af
Comment 4 Nate Graham 2022-09-05 21:19:59 UTC
Git commit 15e2e419821873d0cf0135c5e4973b6033173e26 by Nate Graham.
Committed on 05/09/2022 at 21:19.
Pushed by ngraham into branch 'Plasma/5.25'.

kcms/users: don't let "Choose File…" text overflow

When using a language that's wordier than English and this label becomes
a two-line string, currently the layout breaks and the string overflows
because the Label item that draws it has no maximum height and elision
mode set.

This commit fixes that by setting them accordingly, and also using a
standard icon size for the icon so that there's actually enough room for
two lines of text.
FIXED-IN: 5.24.7


(cherry picked from commit 0dad5f0789c8eb5e4fa893622fdc550898488779)

M  +27   -17   kcms/users/package/contents/ui/UserDetailsPage.qml

https://invent.kde.org/plasma/plasma-workspace/commit/15e2e419821873d0cf0135c5e4973b6033173e26
Comment 5 Nate Graham 2022-09-06 04:57:47 UTC
Git commit aa9d743bfd916c4380fbd26afb067f6dab4cac35 by Nate Graham.
Committed on 05/09/2022 at 21:36.
Pushed by ngraham into branch 'Plasma/5.24'.

kcms/users: don't let "Choose File…" text overflow

When using a language that's wordier than English and this label becomes
a two-line string, currently the layout breaks and the string overflows
because the Label item that draws it has no maximum height and elision
mode set.

This commit fixes that by setting them accordingly, and also using a
standard icon size for the icon so that there's actually enough room for
two lines of text.
FIXED-IN: 5.24.7
(cherry picked from commit 0dad5f0789c8eb5e4fa893622fdc550898488779)

M  +27   -17   kcms/users/package/contents/ui/UserDetailsPage.qml

https://invent.kde.org/plasma/plasma-workspace/commit/aa9d743bfd916c4380fbd26afb067f6dab4cac35