I think it makes sense, imagine you're almost done and Press F5 by mistake, having a dialog that lets you save, not save, cancel, makes sense to me

(In reply to Albert Astals Cid from comment #1)
> I think it makes sense, imagine you're almost done and Press F5 by mistake,
> having a dialog that lets you save, not save, cancel, makes sense to me

As someone who plays the game almost daily, I find it highly annoying and unnecessary. 
It's rare to solve a game on the first go so restarting is a common thing to do for 3 or 4 rounds at least.
An accidental F5 only means you have to start over with the same tiles - something one does anyway.
An intentional F5 now means you have to stop what you are doing and close a dialog.
If it was an intentional change, it is not a benefit and has a negative impact on game play.

Christian do you think it would make sense adding a "Do not ask me again" option to the dialog so it's just always restarted like Stuart wants?

Hello to everyone,

@Stuart K. Smith: Thank you very much for your attention and creating this bug report to make Kmahjongg even better.

From my point of view:

We added this dialog because pressing the wrong button accidently can lead to a restart without asking. Meaning your whole progress gets lost. But there seem to be cases where someone might feel it breaks the gameplay. For me this is a credible objection.

My recommendation would be: Adding an option like ("Don't as for save on restart") in the settings dialog. This option is unchecked by default. Someone has to go into the settings dialog and has the time to really reflect what the consequences are. I would not add it to the dialog itself, cause this might lead to a short unreflected deactivation.

Sounds that like a good way to go for you both?

(In reply to Christian Krippendorf from comment #4)
> Hello to everyone,
> 
> @Stuart K. Smith: Thank you very much for your attention and creating this
> bug report to make Kmahjongg even better.
> 
> From my point of view:
> 
> We added this dialog because pressing the wrong button accidently can lead
> to a restart without asking. Meaning your whole progress gets lost. But
> there seem to be cases where someone might feel it breaks the gameplay. For
> me this is a credible objection.
> 
> My recommendation would be: Adding an option like ("Don't as for save on
> restart") in the settings dialog. This option is unchecked by default.
> Someone has to go into the settings dialog and has the time to really
> reflect what the consequences are. I would not add it to the dialog itself,
> cause this might lead to a short unreflected deactivation.
> 
> Sounds that like a good way to go for you both?

Why would you go to a separate setting in the options dialog instead of the already existing feature of kmessagebox of "don't ask me again"?

I would separate because of it reduces the (In reply to Albert Astals Cid from comment #5)
> (In reply to Christian Krippendorf from comment #4)
> > Hello to everyone,
> > 
> > @Stuart K. Smith: Thank you very much for your attention and creating this
> > bug report to make Kmahjongg even better.
> > 
> > From my point of view:
> > 
> > We added this dialog because pressing the wrong button accidently can lead
> > to a restart without asking. Meaning your whole progress gets lost. But
> > there seem to be cases where someone might feel it breaks the gameplay. For
> > me this is a credible objection.
> > 
> > My recommendation would be: Adding an option like ("Don't as for save on
> > restart") in the settings dialog. This option is unchecked by default.
> > Someone has to go into the settings dialog and has the time to really
> > reflect what the consequences are. I would not add it to the dialog itself,
> > cause this might lead to a short unreflected deactivation.
> > 
> > Sounds that like a good way to go for you both?
> 
> Why would you go to a separate setting in the options dialog instead of the
> already existing feature of kmessagebox of "don't ask me again"?

Because I would suggest it would give a better opportunity of reflecting your action to not be asked anymore. Cause deactivating might lead to an unwanted loss of progress. It is not that you don't think before deactivating in a kmessagebox for 100 %. I would just suggest that the possibility decreases when it is located in the settings dialog. 

Well, this is just my opinion. If one may think this is a no-go because it differs from the kde way in any way, than there is maybe no inbetween solution. Just the option in kmessagebox as you suggest. (Or anything else I can't imagine for now :-))

Greetings

I have no strong opinion, note that the rationale you're giving can be applied to almost 100% of such dialog boxes with a "don't ask me again" checkbox. Example "Firefox warning when closing firefox" where you can totally lose data if you go and click it and say "don't ask me anymore when closing" and then you close firefox while writing a long comment like this and quit before saving changes.

But again, don't really care.

(In reply to Stuart K. Smith from comment #2)
> (In reply to Albert Astals Cid from comment #1)
> > I think it makes sense, imagine you're almost done and Press F5 by mistake,
> > having a dialog that lets you save, not save, cancel, makes sense to me
> 
> As someone who plays the game almost daily, I find it highly annoying and
> unnecessary. 

I second that. I also play kmahjongg a lot, and never accidentally hit "restart game" 
or "new game" hotkeys. I even configured buttons for both into the
toolbar to get there easier. And I find it increasingly annoying to have to deal with the
pop up dialog.

BTW: What I did hit accidentally is "d" to start demo mode instead of "f" for rotating the view,
so I removed "d" from the list of keyboard commands.