Created attachment 151716 [details] Only half of the covers are shown. SUMMARY I have Cover.jpg or Cover.jpeg in all my album directories and also embedded in the files. However, only half of the album covers get shown. Is it possible Elisa ignores the "jpeg" extension? When I renamed cover art in one folder from cover.jpeg to cover.jpg, it got displayed. But some folders with Cover.jpeg get displayed. No Idea why this is happening.
Indeed, it doesn't consider .jpeg. I'll fix it.
Thanks! It would be interesting to find out why the other half of album art got picked up. They are all uniform - all have Cover.jpeg in them and are mostly mp3 (some flac and ogg) - but that does not seem to matter, some mp3 are picked up, some aren't. (None of the ogg are picked up - should I open a bug about that?). I all modified them with easytag, so they really should be fairly uniform. Dolphin displays album art for all of them.
> (None of the ogg are picked up - should I open a bug about that?). If they are ogg/opus files, that's Bug 443519. Otherwise, yeah, file a bug report.
Git commit c63b5d27530d5bc936b670d6e610cf1223d22d9f by Nate Graham. Committed on 31/08/2022 at 20:41. Pushed by ngraham into branch 'master'. Also consider the .jpeg file extension for cover art Added new strings rather than changing "jpg" to "jpe{0,1}g" in the existing ones since it does not appear to be supported by QRegularExpression. FIXED-IN: 22.08.1 M +5 -0 src/filescanner.cpp https://invent.kde.org/multimedia/elisa/commit/c63b5d27530d5bc936b670d6e610cf1223d22d9f
Git commit f71454f3e9802c3a3fa1bc38700767358f4e7714 by Nate Graham. Committed on 31/08/2022 at 20:49. Pushed by ngraham into branch 'release/22.08'. Also consider the .jpeg file extension for cover art Added new strings rather than changing "jpg" to "jpe{0,1}g" in the existing ones since it does not appear to be supported by QRegularExpression. FIXED-IN: 22.08.1 (cherry picked from commit c63b5d27530d5bc936b670d6e610cf1223d22d9f) M +5 -0 src/filescanner.cpp https://invent.kde.org/multimedia/elisa/commit/f71454f3e9802c3a3fa1bc38700767358f4e7714
Thanks! The follow up bugis here: https://bugs.kde.org/show_bug.cgi?id=458571 By the way, in the code you edited: QStringLiteral("*[Cc]over*.jpg") ,QStringLiteral("*[Cc]over*.jpeg") ,QStringLiteral("*[Cc]over*.png") ,QStringLiteral("*[Ff]older*.jpg") ,QStringLiteral("*[Ff]older*.jpeg") ,QStringLiteral("*[Ff]older*.png") ,QStringLiteral("*[Ff]ront*.jpg") ,QStringLiteral("*[Ff]ront*.jpeg") ,QStringLiteral("*[Ff]ront*.png") ,QStringLiteral("*[Aa]lbumart*.jpg") ,QStringLiteral("*[Aa]lbumart*.jpeg") ,QStringLiteral("*[Aa]lbumart*.png") ,QStringLiteral("*[Cc]over*.jpg") ,QStringLiteral("*[Cc]over*.jpeg") ,QStringLiteral("*[Cc]over*.png") I am either blind or the first three lines and the last three lines are duplicated.
You are not blind! Would you be interested in sending a merge request to fix that? I can help.
> You are not blind! Would you be interested in sending a merge request to fix > that? I can help. (In reply to Nate Graham from comment #7) Well, I know how to do that, just my coding abilites are not that great:-). https://invent.kde.org/multimedia/elisa/-/merge_requests/389