Bug 458438 - 'Get New Scripts', 'Install from file' in Kwin Scripts and User-Feedback again translated to English instead remain in German
Summary: 'Get New Scripts', 'Install from file' in Kwin Scripts and User-Feedback agai...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_kwinscripts (other bugs)
Version First Reported In: 5.25.4
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-28 17:09 UTC by alenertz
Modified: 2022-09-23 22:53 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.26
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description alenertz 2022-08-28 17:09:19 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.25.4
KDE Frameworks Version: 5.97.0
Qt Version: 5.15.5

ADDITIONAL INFORMATION
Again a regression in translations.Here my translations: 1) 'Get New Scripts' = Neue Skripte holen
                                                                                                     2) 'Install from File' = Aus Datei installieren
                                                                                                     3) 'You can help KDE improve Plasma....' = 
Here my possible translation: 'Sie können KDE dabei helfen,Plasma zu verbessern,indem Sie Informationen darüber beitragen,wie es zu verwenden ist.so dass wir uns auf die Dinge konzentrieren können,die Ihnen wichtig sind.Informationen dazu beizusteuern ist optional und völlig anonym.Wir sammeln nie Ihre persönlichen Daten,die Dateien,die Sie verwenden,Webseiten,die Sie besuchen oder Informationen,die Sie identifizieren könnten.
Bitte lesen Sie bitte our private policy hier. ' -End of translation.
Comment 1 Bug Janitor Service 2022-09-18 12:11:37 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/2967
Comment 2 Vlad Zahorodnii 2022-09-19 16:34:45 UTC
Git commit fdb40395f02a74de368ec25d8516f7a1d8d04d2c by Vlad Zahorodnii, on behalf of Nicolas Fella.
Committed on 19/09/2022 at 15:01.
Pushed by vladz into branch 'master'.

[kcms/scripts] Make plugin id and translation domain match

KQuickAddons::ConfigModule sets the translation domain based on the plugin id

That is kcm_kwin_scripts. However the translation domain is kcm-kwin-scripts, which breaks loading translations

Also fix Messages.sh to extract from QML

M  +1    -1    src/kcmkwin/kwinscripts/CMakeLists.txt
M  +1    -1    src/kcmkwin/kwinscripts/Messages.sh

https://invent.kde.org/plasma/kwin/commit/fdb40395f02a74de368ec25d8516f7a1d8d04d2c
Comment 3 Vlad Zahorodnii 2022-09-19 17:25:07 UTC
Git commit 76c1d736d14bed72ad204864a059e96f71c4d9ed by Vlad Zahorodnii, on behalf of Nicolas Fella.
Committed on 19/09/2022 at 17:25.
Pushed by vladz into branch 'Plasma/5.26'.

[kcms/scripts] Make plugin id and translation domain match

KQuickAddons::ConfigModule sets the translation domain based on the plugin id

That is kcm_kwin_scripts. However the translation domain is kcm-kwin-scripts, which breaks loading translations

Also fix Messages.sh to extract from QML


(cherry picked from commit fdb40395f02a74de368ec25d8516f7a1d8d04d2c)

M  +1    -1    src/kcmkwin/kwinscripts/CMakeLists.txt
M  +1    -1    src/kcmkwin/kwinscripts/Messages.sh

https://invent.kde.org/plasma/kwin/commit/76c1d736d14bed72ad204864a059e96f71c4d9ed