Bug 458331 - Bugs in Windows 7z package
Summary: Bugs in Windows 7z package
Status: RESOLVED FIXED
Alias: None
Product: kasts
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: bart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-26 08:18 UTC by rbharathkumar
Modified: 2023-03-02 08:50 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
On Clicking Storage Settings (13.78 KB, image/jpeg)
2022-08-26 08:18 UTC, rbharathkumar
Details
Playback Speed (1.69 KB, image/jpeg)
2022-08-26 08:19 UTC, rbharathkumar
Details
Display Centering (15.93 KB, image/jpeg)
2022-08-26 08:19 UTC, rbharathkumar
Details
Setting Page Alignment (21.28 KB, image/jpeg)
2022-08-26 08:19 UTC, rbharathkumar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description rbharathkumar 2022-08-26 08:18:19 UTC
Created attachment 151604 [details]
On Clicking Storage Settings

SUMMARY
Hi All,
Even though the windows build is not official, wanted to share some of the bugs and feature wishlist.
Please note this is just my personal opinion and not a demand for feature. I am appreciative that Free/KDE software is even available for windows users.

STEPS TO REPRODUCE
1. Navigate to the Binary-Factory
2. Download the 7z file relevant to Windows 64bit (kasts-master-328-windows-msvc2019_64-cl.7z)
3. Extract to folder and run the exe within the bin folder.
4. Add podcast to queue and listen.

OBSERVED RESULT
1. The Storage option in the Settings App is broken. It leads to an empty screen as shown in attached screenshot.
2. Discover tab does not load any suggestions.
3. Change in voice when playback speed is increased. No issues when played at normal speed.
	I tried below podcast at 1.25 times the speed.
	https://7goodminutes.com/podcast/how-to-be-unstoppable
4. The playback speed by default is showing up as zero. Please refer to attached screenshot.
5. The screenshot of the channel on the playback screen can be a little centered. Please refer to attached screenshot.

Features Wishlist - Would be nice to have.
Please note this is just my personal opinion and not a demand for feature. I am appreciative that Free/KDE software is even available for windows users.

1. A streaming option in addition to the download option.
2. The played episodes can be greyed out a little to differentiate from the unplayed ones. This can work along side the played label on the 
3. Ability to set below options at global level.
	3.1. Default Playback speed.
	3.2. Ability to increase playback speed in scale of 0.1 instead of 0.25.
		 Personal Note - Playback speed at 1.3 or 1.4 is a sweetspot
	3.3. Default Seek timer - Instead of 10 seconds default.
	3.4. Default Sleep timer.
4. Option to seek forward and backward using keyboard.
5. Ability to sort queue based on podcast title and podcast duration.
6. Dark Mode.
7. In-Place Update.
8. Personal observation - Not applicable for all. Please ignore if not applicable.
	In the settings, the options look like they are hanging. For example, in Queue Settings, the empty space above the New Episodes appears as if something was supposed to get loaded but did not get loaded.
	They are perfectly symmetrical, no issues with that and logical as well. A main heading followed by a sub heading, but the empty spaces kind of looks a little awkward.

EXPECTED RESULT
No Failures or options made available.

SOFTWARE/OS VERSIONS
Windows: Windows 10 21H2
macOS: NA
Linux/KDE Plasma: NA
(available in About System)
KDE Plasma Version: NA
KDE Frameworks Version: 5.97 (From About Page)
Qt Version: 5.15.5 (From About Page)

ADDITIONAL INFORMATION
Positive Feedback on the App:
1. Very cool app icon.
2. Excellent work on the player. The import from .opml file was excellent and fast.
3. Great job in marking the episodes as played on import.
4. Sound quality was good, no crackling sounds as found in few podcast apps.
Comment 1 rbharathkumar 2022-08-26 08:19:10 UTC
Created attachment 151605 [details]
Playback Speed
Comment 2 rbharathkumar 2022-08-26 08:19:30 UTC
Created attachment 151606 [details]
Display Centering
Comment 3 rbharathkumar 2022-08-26 08:19:52 UTC
Created attachment 151607 [details]
Setting Page Alignment
Comment 4 bart 2023-01-20 21:11:31 UTC
Some comments regarding the latest state of things on windows: 

> 1. The Storage option in the Settings App is broken. It leads to an empty
> screen as shown in attached screenshot.

This is a qt and kde xdg portal issue: it either works on windows or on flatpak linux.  Since we have a lot more users using flatpak, I'm afraid this doesn't work on windows right now.  I'm trying to find the right place to file a bug report on the component causing the issue.

> 2. Discover tab does not load any suggestions.

Tested this today; seems to work.  If you type something and press enter or the search button, you should get results.

> 3. Change in voice when playback speed is increased. No issues when played
> at normal speed.
> 	I tried below podcast at 1.25 times the speed.
> 	https://7goodminutes.com/podcast/how-to-be-unstoppable
> 4. The playback speed by default is showing up as zero. Please refer to
> attached screenshot.

Both issues are now solved with a major audio backend update.  The backend even allows streaming.

> 5. The screenshot of the channel on the playback screen can be a little
> centered. Please refer to attached screenshot.

This is a design decision: on KDE plasma the header bar blends in with the top window bar so it becomes one surface of the same colour.  I agree it doesn't look that nice on windows.  I'm working on a revamp of the header controls which would look everywhere.  It should be in the next release.

> Features Wishlist - Would be nice to have.
> Please note this is just my personal opinion and not a demand for feature. I
> am appreciative that Free/KDE software is even available for windows users.
> 
> 1. A streaming option in addition to the download option.

Is available since 22.11 (or 22.09, I forgot :) )

> 2. The played episodes can be greyed out a little to differentiate from the
> unplayed ones. This can work along side the played label on the 

The original Kasts application had this, but I got a lot of negative feedback for that. People said that the lists looked "washed out".  But I kind of agree with you on this one.

> 3. Ability to set below options at global level.
> 	3.1. Default Playback speed.
> 	3.2. Ability to increase playback speed in scale of 0.1 instead of 0.25.
> 		 Personal Note - Playback speed at 1.3 or 1.4 is a sweetspot

On the todo list.  There's even a branch that has it half-implemented.  Will happen in the future.

> 	3.3. Default Seek timer - Instead of 10 seconds default.

It's been on my list for quite a long time.  It's not even that hard to implement.  It will happen at some point in the near future.

> 	3.4. Default Sleep timer.

Kasts will remember your last setting.

> 4. Option to seek forward and backward using keyboard.

This already works with media keys.  I'm not sure which keys to bind it to on a regular keyboard though.  The arrows are already used for navigation.

> 5. Ability to sort queue based on podcast title and podcast duration.

A search feature is on the todo list.

> 6. Dark Mode.

Is already there for linux.  I have no clue how to do this for windows, though.

> 7. In-Place Update.

Also not sure what to do.  I'm reusing the KDE windows build infrastructure.  I don't any of the details of the flow. :-)

> 8. Personal observation - Not applicable for all. Please ignore if not
> applicable.
> 	In the settings, the options look like they are hanging. For example, in
> Queue Settings, the empty space above the New Episodes appears as if
> something was supposed to get loaded but did not get loaded.
> 	They are perfectly symmetrical, no issues with that and logical as well. A
> main heading followed by a sub heading, but the empty spaces kind of looks a
> little awkward.

The settings have been completely revamped using a new framework.  So that should solve the issues you've mentioned.

> ADDITIONAL INFORMATION
> Positive Feedback on the App:
> 1. Very cool app icon.
> 2. Excellent work on the player. The import from .opml file was excellent
> and fast.
> 3. Great job in marking the episodes as played on import.
> 4. Sound quality was good, no crackling sounds as found in few podcast apps.

Thanks!  Very much appreciated.
Comment 5 bart 2023-01-23 19:48:15 UTC
Git commit d869358ff5031e4a6976d2bf5bf26278583bfc83 by Bart De Vries.
Committed on 23/01/2023 at 12:29.
Pushed by bdevries into branch 'master'.

Header bar redesign

New scalable header bar design which should scale nicely with height
and width changes by collapsing several elements (putting them into
popups and overflow menus).  The height scaling of the header is
similar to Elisa, where it will use the regular background color when
fully collapsed.
Titles are clickable and will open the relevant pages.  Images are also
clickable and that will open a fullscreen view.
This new design also exposes volume controls both for desktop and mobile
layout.
Related: bug 457846

M  +2    -1    src/CMakeLists.txt
M  +1    -1    src/qml/ChapterListDelegate.qml
A  +438  -0    src/qml/Desktop/DesktopPlayerControls.qml     [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)]
A  +241  -0    src/qml/Desktop/HeaderBar.qml     [License: GPL(v2.0+)]
M  +1    -1    src/qml/DiscoverPage.qml
M  +1    -1    src/qml/EntryPage.qml
M  +1    -0    src/qml/FeedDetailsPage.qml
A  +205  -0    src/qml/FullScreenImage.qml     [License: GPL(v3.0)]
M  +1    -1    src/qml/GenericEntryDelegate.qml
M  +25   -21   src/qml/GenericHeader.qml
D  +0    -314  src/qml/HeaderBar.qml
M  +5    -2    src/qml/ImageWithFallback.qml
R  +0    -0    src/qml/Mobile/BottomToolbar.qml [from: src/qml/BottomToolbar.qml - 100% similarity]
R  +1    -1    src/qml/Mobile/FooterBar.qml [from: src/qml/FooterBar.qml - 099% similarity]
R  +0    -0    src/qml/Mobile/MinimizedPlayerControls.qml [from: src/qml/MinimizedPlayerControls.qml - 100% similarity]
R  +68   -0    src/qml/Mobile/MobilePlayerControls.qml [from: src/qml/PlayerControls.qml - 085% similarity]
M  +13   -2    src/qml/main.qml
M  +7    -5    src/resources.qrc

https://invent.kde.org/plasma-mobile/kasts/commit/d869358ff5031e4a6976d2bf5bf26278583bfc83
Comment 6 Bug Janitor Service 2023-02-28 13:12:46 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/kasts/-/merge_requests/106
Comment 7 bart 2023-02-28 14:03:44 UTC
Git commit 6e998d608ce8b693b611015f0fb252bf63c5a1cf by Bart De Vries.
Committed on 28/02/2023 at 13:09.
Pushed by bdevries into branch 'master'.

Use FolderDialog for non-flatpak builds

Flatpaks have a problem with FolderDialog from labs: it never returns a
path.  Therefore Kasts was - up to now - using FileDialog from QtQuick1.
However, this was causing problems on Android and Windows.  Now we only
use QtQuick1 FileDialog for flatpak and FolderDialog everywhere else.

M  +3    -0    .flatpak-manifest.json
M  +12   -0    src/CMakeLists.txt
A  +17   -0    src/qml/Settings/StorageDirDialog.qml     [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)]
A  +17   -0    src/qml/Settings/StorageDirDialogFlatpak.qml     [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)]
M  +1    -6    src/qml/Settings/StorageSettingsPage.qml
A  +7    -0    src/resources-flatpak.qrc
A  +7    -0    src/resources-non-flatpak.qrc

https://invent.kde.org/multimedia/kasts/commit/6e998d608ce8b693b611015f0fb252bf63c5a1cf
Comment 8 bart 2023-02-28 14:14:06 UTC
Will probably close this report later today if the storage settings menu issue is solved in today's windows build.

Most of the issues that were mentioned here have been solved.  For any remaining issues or feature requests, please open separate bugs for each one of them.  It's quite hard to track a dozen of things in one report.
Comment 9 rbharathkumar 2023-02-28 15:41:07 UTC
(In reply to bart from comment #8)
> Will probably close this report later today if the storage settings menu
> issue is solved in today's windows build.
> 
> Most of the issues that were mentioned here have been solved.  For any
> remaining issues or feature requests, please open separate bugs for each one
> of them.  It's quite hard to track a dozen of things in one report.

Thank you for all your hard work and on working on this...
I will try to update my install and test it out over the weekend...
Comment 10 bart 2023-03-01 18:57:34 UTC
Settings issue is solved, so closing this report. As mentioned, feel free to open new ones (one feature/bug per report).
Comment 11 rbharathkumar 2023-03-02 08:50:58 UTC
(In reply to bart from comment #10)
> Settings issue is solved, so closing this report. As mentioned, feel free to
> open new ones (one feature/bug per report).

Thank you very much for the update...
Had the chance to download and try out the changes.
Note that I am using the portable Windows 10 version - **kasts-master-517-windows-cl-msvc2019-x86_64.7z** since I do not have the necessary permissions.

1. The storage window issue is fixed - super job...
2. I totally love the playback speed menu where I can add a custom playback speed. I don't think any other app has this useful feature.

**Observations: **
I can open separate issues if needed based on your confirmations. 

1. The queueing system does not seem to work. After current episode completes, the next one does not start. The option "Automatically play next episode when current episode finishes." is enabled in the settings.
2. The playback speed and volume controls do not persist across app restarts. Gets reset to 1.00 and 100% respectively.
3. Observations on Podcast Update
	3.1. In case a podcast fails to update (due to some error/URL changes outside the app) the errors are logged in the ErrorLog inside settings but no notification is provided to the user. 
	A "Podcast Update Error" pop up with link to Error Log comes up only for a short time, but again disappears if I did not catch it.
	This is totally fine, but a visual red mark or something which we can dismiss that shows that we have had an error while updating would be nice to have.
	3.2. Some of the episode thumbnails if they fail to load, it shows a gear icon constantly spinning. Occurs in very less cases. 
		 e.g. Podcase Name: Today Explained
		       Episode Name: Block the sun, Save the earth. (Happens for all episodes in this podcast)
4. Few personal observations - Ignore if not applicable.
	4.1. While handy to have the export and import subscriptions options on the subscriptions page, it would be nice to have the same in the Settings Page as well.
	4.2. Played episodes can be greyed out a little or a visual cue like on the emails or just a marker so that we can visually differentiate instead of seeing the Played text.
	4.3. The marker NEW vs Played is a bit off. If I follow the sequence 
		Open App - Update - Play some episodes marked NEW - close and then reopen the app
		It is working, but not sure, if it is working as expectation.
		Consider this just as my lack of understanding but please do have a look...
	
As always great job with the app. Truly excellent.
Please feel free to let me know the numbers which are confirmed I can open a separate issue for them.