Bug 458222 - Network QR codes have insufficient quiet zone
Summary: Network QR codes have insufficient quiet zone
Status: RESOLVED FIXED
Alias: None
Product: frameworks-prison
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: 5.97.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Sune Vuorela
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-23 19:54 UTC by Nagy Tibor
Modified: 2022-10-01 15:17 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/prison/commit/b17216263ba1ae1c2896b5ead715cb52622e268f
Version Fixed/Implemented In: 5.99
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nagy Tibor 2022-08-23 19:54:41 UTC 
SUMMARY
The QR codes that the network applet shows on "Show network's QR code" are not spec compliant, they have insufficient quiet zone around the symbol. Spec says the quiet zone around normal-sized QR codes should be at least 4 modules instead of the current 2 modules.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.25
KDE Plasma Version: 5.25.3
KDE Frameworks Version: 5.96.0
Qt Version: 5.15.5
Graphics Platform: X11
Comment 1 Nate Graham 2022-08-30 21:50:59 UTC 
This barcode image comes from Prison; moving the bug report there.
Comment 2 Sune Vuorela 2022-10-01 10:26:29 UTC 
Git commit c3133beb21decdbf44c74eb89ffe2471af04f897 by Sune Vuorela.
Committed on 01/10/2022 at 10:25.
Pushed by sune into branch '458222-increase-qrcode-quiet-zone'.

Increase quiet zone for qrcode

M  +1    -1    src/lib/qrcodebarcode.cpp

https://invent.kde.org/frameworks/prison/commit/c3133beb21decdbf44c74eb89ffe2471af04f897
Comment 3 Sune Vuorela 2022-10-01 12:31:51 UTC 
Git commit b17216263ba1ae1c2896b5ead715cb52622e268f by Sune Stolborg Vuorela.
Committed on 01/10/2022 at 12:31.
Pushed by sune into branch 'master'.

Increase quiet zone for qrcode

Closes #458222

M  +-    --    autotests/qr/qr-binary.png
M  +-    --    autotests/qr/qr-text.png
M  +1    -1    src/lib/qrcodebarcode.cpp

https://invent.kde.org/frameworks/prison/commit/b17216263ba1ae1c2896b5ead715cb52622e268f