Bug 458161 - Storage size display should follow BinaryUnitDialect option
Summary: Storage size display should follow BinaryUnitDialect option
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Disks & Devices (show other bugs)
Version: 5.24.6
Platform: Other Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-22 09:10 UTC by Erik Quaeghebeur
Modified: 2023-07-21 21:32 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kcoreaddons/-/commit/58cb8fcc5f8290cf2ecac5c3f5ebd9ac69aa8f10
Version Fixed In: Frameworks 6.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Quaeghebeur 2022-08-22 09:10:36 UTC 
SUMMARY
The plasma disk and devices applet does not seem to follow the BinaryUnitDialect config option. Normally it is just a matter of replacing some function with some higher-level ones.

STEPS TO REPRODUCE
1. Set BinaryUnitDialect=2 in [Locale] section of $KDEHOME/.config/kdeglobals (setting to metric/SI instead of IEC)
2. Look at applet with some storage devices plugged in
3. Look for size info underneath device name

OBSERVED RESULT
GiB is used instead of GB (the latter would be correct given the described settings in $KDEHOME/.config/kdeglobals)

EXPECTED RESULT
Metric formatting is used

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.24.6
KDE Frameworks Version: 5.96.0
Qt Version: 5.15.5

ADDITIONAL INFORMATION
The BinaryUnitDialect config option is described in Bug 57240. This option is for now still without a GUI, but Bug 364321 makes it clear this is about to change. So apps like the plasma disk and devices applet should be made ready to follow BinaryUnitDialect.

It may be that there are other plasma components that need the same fix applied.
Comment 1 Nate Graham 2023-07-21 21:32:56 UTC 
Fixed by Jack Hill with https://invent.kde.org/frameworks/kcoreaddons/-/commit/58cb8fcc5f8290cf2ecac5c3f5ebd9ac69aa8f10 in Frameworks 6.0